Date: Thu, 8 Aug 2019 15:29:59 -0600 From: Warner Losh <imp@bsdimp.com> To: "Conrad E. Meyer" <cem@freebsd.org> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r350778 - head/sys/contrib/zstd/lib/common Message-ID: <CANCZdfomnEHR5ov8Kcjp_NJFah52x9hBK-RJtEeO1YuHEuKm5g@mail.gmail.com> In-Reply-To: <CAG6CVpX3UyzYXxu-mZMev5qfOw=fBRH4vH4EKYtMantnXA-fBw@mail.gmail.com> References: <201908082009.x78K9bCV069231@repo.freebsd.org> <CAG6CVpX3UyzYXxu-mZMev5qfOw=fBRH4vH4EKYtMantnXA-fBw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Thanks Conrad for upstreaming... Warner On Thu, Aug 8, 2019 at 3:29 PM Conrad Meyer <cem@freebsd.org> wrote: > Thanks Warner for noticing and fixing this. > > I've sent the patch upstream to hopefully be addressed there as well: > > https://github.com/facebook/zstd/pull/1713 > > Best, > Conrad > > On Thu, Aug 8, 2019 at 1:09 PM Warner Losh <imp@freebsd.org> wrote: > > > > Author: imp > > Date: Thu Aug 8 20:09:36 2019 > > New Revision: 350778 > > URL: https://svnweb.freebsd.org/changeset/base/350778 > > > > Log: > > Stopgap fix for gcc platforms. > > > > Our in-tree gcc doesn't have a no-tree-vectorize optimization knob, so > we get a > > warning that it's unused. This causes the build to fail on all our gcc > platforms. > > Add a quick version check as a stop-gap measure to get CI building > again. > > > > Modified: > > head/sys/contrib/zstd/lib/common/compiler.h > > > > Modified: head/sys/contrib/zstd/lib/common/compiler.h > > > ============================================================================== > > --- head/sys/contrib/zstd/lib/common/compiler.h Thu Aug 8 20:07:38 > 2019 (r350777) > > +++ head/sys/contrib/zstd/lib/common/compiler.h Thu Aug 8 20:09:36 > 2019 (r350778) > > @@ -128,7 +128,7 @@ > > } > > > > /* vectorization */ > > -#if !defined(__clang__) && defined(__GNUC__) > > +#if !defined(__clang__) && defined(__GNUC__) && __GNUC__ > 5 > > # define DONT_VECTORIZE __attribute__((optimize("no-tree-vectorize"))) > > #else > > # define DONT_VECTORIZE > > >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfomnEHR5ov8Kcjp_NJFah52x9hBK-RJtEeO1YuHEuKm5g>