From owner-svn-ports-head@freebsd.org Wed Jan 4 19:03:00 2017 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 68338C9F068 for ; Wed, 4 Jan 2017 19:03:00 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: from mail-oi0-x243.google.com (mail-oi0-x243.google.com [IPv6:2607:f8b0:4003:c06::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2BD701EFB for ; Wed, 4 Jan 2017 19:03:00 +0000 (UTC) (envelope-from sunpoet@sunpoet.net) Received: by mail-oi0-x243.google.com with SMTP id f201so76027543oib.0 for ; Wed, 04 Jan 2017 11:03:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sunpoet-net.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=OKFoU3JBL0r5kpbF5mJTU4UagPJuiwsNHM58VtKI8Q0=; b=HGsW7i8iCnV8REYPj8pFIr91VF7Ta7E+QfvroB017/uylo0IXqQZ39KpBg8q7I8Mz2 21t0pJVbK/o8pRbiGTyW+SCuHCpatH0lQCpwKGGUToTt0rNWZwS+aFQTjkBjDp63sj7v BS3XQZMDDjGUo7tkfPi3oKBx7JXx7uy7K+sLRrzntkJ5HWSZDg7o69zYl/KPXXMfFwZG m+SrBtb/EJFVuhvly4rE0sxnVa06HvLkZvZ37796SdsOmjDtqSfjWl5QwRd5HmmO7duY oJZ+mlGIWuTSDOBZ3MNICfhmrQNQuuCst7NG35gdQf849pu07MBsS0UO+SBIHzKc4j6a dLxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=OKFoU3JBL0r5kpbF5mJTU4UagPJuiwsNHM58VtKI8Q0=; b=PvErIKs9lfhtW0EXcghYXge4k1ocpLBE/ThJUHArwLlMBG8jKtwnlFjIbbOSl/Fw/S Zf5IC7ng89766X9yn/L+XhlckCD35ddiG/4QxEsAluDbs4It6qZTqTpyjs/c/Zg4V3NT jWm7Vr3BDEaTTELKWnlQ7icfZ4YC9naDxG2lZwqFeNty5tiFeChynbZ6NDEnyDBL/Hy3 2zpFMq6eVJrFB7cMju4HIj8YyJbpJunUZIxAOXNafMecD2iLwD8dGLZscSVBRKnn6aFr 4JLV0ghSax1OwguwQWF1gGNnMSk/SaC97XTIKVr2BVxDR2TzksMQjJZ7x09DeadvCBt7 jS/g== X-Gm-Message-State: AIkVDXLnutYEQ8rvx7wEDWFLH05DfCTKPqINv576zTtYG36hh6nQ/pC107lAVF4vRPNRhusGFdvs01iFrv9N0A== X-Received: by 10.157.11.124 with SMTP id p57mr31766646otd.76.1483556579599; Wed, 04 Jan 2017 11:02:59 -0800 (PST) MIME-Version: 1.0 Sender: sunpoet@sunpoet.net Received: by 10.157.12.134 with HTTP; Wed, 4 Jan 2017 11:02:18 -0800 (PST) In-Reply-To: <20170103111542.37681315A@freefall.freebsd.org> References: <201701010417.v014HjI0080871@repo.freebsd.org> <20170103111542.37681315A@freefall.freebsd.org> From: Sunpoet Po-Chuan Hsieh Date: Thu, 5 Jan 2017 03:02:18 +0800 X-Google-Sender-Auth: a64qy0PDJ3S_uoj8ux1-PHFZYV4 Message-ID: Subject: Re: svn commit: r430238 - head/databases/rocksdb To: Jan Beich Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jan 2017 19:03:00 -0000 On Tue, Jan 3, 2017 at 7:15 PM, Jan Beich wrote: > Sunpoet Po-Chuan Hsieh writes: > > > --- head/databases/rocksdb/Makefile Sun Jan 1 03:57:43 2017 > (r430237) > > +++ head/databases/rocksdb/Makefile Sun Jan 1 04:17:45 2017 > (r430238) > > @@ -50,10 +50,6 @@ ZSTD_LIB_DEPENDS= libzstd.so:archivers/z > > > > .include > > > > -.if ${OSVERSION} <= 1000000 > > -CFLAGS+= -D_GLIBCXX_USE_C99 > > -.endif > > - > > This may be premature. The underlying issue is documented in bug 193528 > and has only been fixed in lang/gcc6 but not in lang/gcc or lang/gcc5. > Architectures still stuck with base GCC (sparc64, powerpc*, mips*) are > going to be BROKEN. And let's not forget users that prefer GCC over > Clang for various reasons e.g., -Og, -flto, -fopenmp on i386, Graphite. > Hello Jan, Thanks for pointing it out. The section was added by zi@ with commit log "Fix build when using FreeBSD older than 10.0". If this failure exists in all GCC prior to 6.x, I guess the solution would looks like (not tested yet): Index: Makefile =================================================================== --- Makefile (revision 430546) +++ Makefile (working copy) @@ -48,8 +48,14 @@ LZ4_LIB_DEPENDS= liblz4.so:archivers/liblz4 ZSTD_LIB_DEPENDS= libzstd.so:archivers/zstd +USES+= compiler:features + .include +.if ${COMPILER_TYPE} == gcc && ${COMPILER_VERSION} <= 60 +CFLAGS+= -D_GLIBCXX_USE_C99 +.endif + .if ${COMPILER_TYPE} == clang && ${COMPILER_VERSION} >= 36 CXXFLAGS+= -Wno-inconsistent-missing-override .endif Regards, sunpoet > $ uname -rp > 12.0-CURRENT amd64 > $ pkg install -qy gcc > $ make clean all CC=gcc49 CXX=g++49 CPP=cpp49 > [...] > util/options_helper.cc: In function 'uint64_t rocksdb::ParseUint64(const > string&)': > util/options_helper.cc:260:18: error: 'stoull' is not a member of 'std' > uint64_t num = std::stoull(value.c_str(), &endchar); > ^ > util/options_helper.cc: In function 'int rocksdb::{anonymous}::ParseInt(const > string&)': > util/options_helper.cc:378:13: error: 'stoi' is not a member of 'std' > int num = std::stoi(value.c_str(), &endchar); > ^ > util/options_helper.cc: In function 'double rocksdb::{anonymous}::ParseDouble(const > string&)': > util/options_helper.cc:416:10: error: 'stod' is not a member of 'std' > return std::stod(value); > ^ > util/options_helper.cc:420:1: warning: control reaches end of non-void > function [-Wreturn-type] > } > ^ > _______________________________________________ > svn-ports-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-ports-all > To unsubscribe, send any mail to "svn-ports-all-unsubscribe@freebsd.org" >