Date: Sat, 12 Feb 2011 16:51:26 -0500 (EST) From: Rick Macklem <rmacklem@uoguelph.ca> To: =?utf-8?Q?Tom=C3=A1=C5=A1_Drbohlav?= <drb@karlov.mff.cuni.cz> Cc: freebsd-fs@freebsd.org Subject: Re: NFSv4 ACLs on NFS4 mount ? Message-ID: <801619581.1863246.1297547486791.JavaMail.root@erie.cs.uoguelph.ca> In-Reply-To: <4D551C0C.1050600@karlov.mff.cuni.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
>
> Lovely, works as expected. Thanks!
>
Good to hear. I'll admit neither George or I had tested ZFS.
> Only minor note, server-nfsv4acl.patch expect slightly different code
> before (and after):
>
> ...
> NFSVOPLOCK(vp, LK_EXCLUSIVE | LK_RETRY, p);
> ...
>
> in 8.1-p1 vs.
>
> ...
> if (vn_lock(vp, LK_SHARED) == 0) {
> ...
>
> I attach patch against 8.1-p1 I finally used.
>
Yep, your patch is fine. (All that needs to be done is
replace the VOP_ACCESS() call with VOP_ACCESSX() as you've
done.)
rick
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?801619581.1863246.1297547486791.JavaMail.root>