Date: Thu, 29 Aug 2019 15:02:15 +0200 From: Kirill Ponomarev <kp@krion.cc> To: Cy Schubert <Cy.Schubert@cschubert.com> Cc: Baptiste Daroussin <bapt@freebsd.org>, Kirill Ponomarev <krion@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r510145 - head/sysutils/screen Message-ID: <20190829130215.GA20329@krion.cc> In-Reply-To: <201908291254.x7TCsFCI051889@slippy.cwsent.com> References: <201908290638.x7T6cVFc033808@repo.freebsd.org> <201908291230.x7TCUgKI027625@slippy.cwsent.com> <20190829124225.r7gpumnvtbeguuoz@ivaldir.net> <201908291254.x7TCsFCI051889@slippy.cwsent.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--y0ulUmNC+osPPQO6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 08/29, Cy Schubert wrote: > In message <20190829124225.r7gpumnvtbeguuoz@ivaldir.net>, Baptiste=20 > Daroussin wr > ites: > >=20 > > > > --vmfceac25l47d6el > > Content-Type: text/plain; charset=3Dus-ascii > > Content-Disposition: inline > > Content-Transfer-Encoding: quoted-printable > > > > On Thu, Aug 29, 2019 at 05:30:42AM -0700, Cy Schubert wrote: > > > In message <201908290638.x7T6cVFc033808@repo.freebsd.org>, Kirill Pon= omar=3D > > ev=3D20 > > > wri > > > tes: > > > > Author: krion > > > > Date: Thu Aug 29 06:38:31 2019 > > > > New Revision: 510145 > > > > URL: https://svnweb.freebsd.org/changeset/ports/510145 > > > > > > > > Log: > > > > Remove building man page by default. It's currently broken on HEAD > > > > and requires to build textproc/groff which requires devel/llvm80 > > > > which is an overkill for using screen. > > > > > > > > Modified: > > > > head/sysutils/screen/Makefile > > > > > > > > Modified: head/sysutils/screen/Makefile > > > > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D= =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D > > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D= =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D > > =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D= =3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D3D=3D > > =3D3D=3D3D=3D3D=3D3D > > > > =3D3D > > > > --- head/sysutils/screen/Makefile Thu Aug 29 06:37:17 2019 (r51014 > > > > 4) > > > > +++ head/sysutils/screen/Makefile Thu Aug 29 06:38:31 2019 (r51014 > > > > 5) > > > > @@ -3,7 +3,7 @@ > > > > =3D20 > > > > PORTNAME=3D3D screen > > > > PORTVERSION=3D3D 4.6.2 > > > > -PORTREVISION=3D3D 1 > > > > +PORTREVISION=3D3D 2 > > > > CATEGORIES=3D3D sysutils > > > > MASTER_SITES=3D3D GNU \ > > > > ftp://ftp.gnu.org/gnu/screen/ \ > > > > @@ -20,7 +20,7 @@ COMMENT=3D3D Multi-screen window manager > > > > LICENSE=3D3D GPLv3 > > > > =3D20 > > > > OPTIONS_DEFINE=3D3D INFO MAN NETHACK XTERM_256 SHOWENC SYST > > EM_SCREE > > > > NRC > > > > -OPTIONS_DEFAULT=3D3D INFO MAN NETHACK XTERM_256 SOCKETS SYSTEM_SCR= EE > > NRC \ > > > > +OPTIONS_DEFAULT=3D3D INFO NETHACK XTERM_256 SOCKETS SYSTEM_SCREENR= C=20 > > \ > > > > NCURSES_DEFAULT > > > > OPTIONS_SINGLE=3D3D IPC NCURSES > > > > OPTIONS_SINGLE_IPC=3D3D SOCKETS NAMED_PIPES > > > > > > >=3D20 > > > Should you not have obtained maintainer approval for this first? > > >=3D20 > > > And now the package will not include man pages. Can I assign those PR= s to=3D > > =3D20 > > > you? > > >=3D20 > > > > I do think the best approach to this is to drop the MAN page option, it= mak=3D > > es > > little sense not to install it. and not add groff as a runtime dependen= cy > > anyway. >=20 > I've had this same issue with krb5. Pkg end users expect man pages. >=20 > > > > The reason why man(1) is telling the users to install groff(1) is exact= ly f=3D > > or > > that, the users do decide if he wants to read that manpage on his syste= m an=3D > > d do > > install groff, or he reads it online and do not install it at all. the = other > > point is in the future screen(1) might become mandoc compatible. and yo= u wi=3D > > ll > > still grab in the groff(1) dependency. >=20 > I'm willing to live with this but it is still disrespectful not to involv= e=20 > the maintainer. >=20 > Can I point to this email thread as a precedent if or when I commit to a= =20 > port maintained by someone else? Cy, I totally understand your concerns and feelings about this action, I apologize if I offended you with this commit. My initial thought was: why I need to build groff for screen which requires llvm80, I tried to open screen man page on current and got this: This manpage needs groff(1) to be rendered First install groff(1): pkg install groff screen was built with MAN option though. It seemed this is not intended and port is broken. Probably fixing it this way was too rude but it was the fastest way I could find. Sorry for that again. --y0ulUmNC+osPPQO6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEJCHRFhEAQujKni1pDyI9/LMCykUFAl1nzNcACgkQDyI9/LMC ykXO+wf9FzECzaP2R4+5pPLr5eiGYinDMKtqdqbo47W4DqNxih48zquRQKfm/ZQy JcKXYd9tdJm2ofznVm+6DEVwEE471R3Z9ZFRTKgaRZbyUUXyXMmb8P1Uw80fSDWM 74upUqyvQ+c9AkYWnaj5lycg1gzLUIMg/P1wjxsckJ8vclAyJnGtfptVSVp0vu++ 2dbZnsJgaqjRiGUTsrwJpWAL4nMEfxzlmtknSo5nTkkLJKTcQU8nhv1zdRkUf6/p iPmrZsN0H9gpiGDqKKoAE3RfNzDWCqOkekksfO/jFH1W66jlQNLEZcyRlVSJp1m4 PRgzMzqytAq6y8dB4GSiQkSTtFOS2Q== =O9TH -----END PGP SIGNATURE----- --y0ulUmNC+osPPQO6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190829130215.GA20329>