From owner-freebsd-chromium@FreeBSD.ORG Sun Mar 27 15:38:40 2011 Return-Path: Delivered-To: freebsd-chromium@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 269A9106566C for ; Sun, 27 Mar 2011 15:38:40 +0000 (UTC) (envelope-from evanm@google.com) Received: from smtp-out.google.com (smtp-out.google.com [216.239.44.51]) by mx1.freebsd.org (Postfix) with ESMTP id B16268FC14 for ; Sun, 27 Mar 2011 15:38:39 +0000 (UTC) Received: from hpaq3.eem.corp.google.com (hpaq3.eem.corp.google.com [172.25.149.3]) by smtp-out.google.com with ESMTP id p2RFcc1q030650 for ; Sun, 27 Mar 2011 08:38:38 -0700 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=google.com; s=beta; t=1301240318; bh=NkbjNo5QixmT+DsaaRCxtce8Hko=; h=MIME-Version:Sender:In-Reply-To:References:Date:Message-ID: Subject:From:To:Cc:Content-Type:Content-Transfer-Encoding; b=S7CQQkfIGUJO7VeN4MfRjzjOAGaSkGDQXha0HQLP2I4aH+vUhYvA1rJtudPRfEqad SX6OSgkvnGUJChQeClrBg== Received: from iyf13 (iyf13.prod.google.com [10.241.50.77]) by hpaq3.eem.corp.google.com with ESMTP id p2RFcZvZ011047 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Sun, 27 Mar 2011 08:38:36 -0700 Received: by iyf13 with SMTP id 13so3881986iyf.14 for ; Sun, 27 Mar 2011 08:38:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=beta; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=hBjh3Yg1ntbC37AsmcsUQ//0fqu9SXikgQe+daNfsEk=; b=U+z/qf04tv5YODvHFkUq2ZsPQeBfwQdMv6Ns7ArGPSPjHlAgBrVKSV5UtrtuWsho+p W76EuHJ3KouwltbkbdPw== DomainKey-Signature: a=rsa-sha1; c=nofws; d=google.com; s=beta; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=bQ43u1ZiNs71GYHMjy3kTmszSQUHlQdFhakpXwQb1mJQ6BM+y5Xg4yKiKMwrEF8ecM G+c9ZR02USkxo9kDW0/g== MIME-Version: 1.0 Received: by 10.43.57.78 with SMTP id wf14mr5052552icb.138.1301240315156; Sun, 27 Mar 2011 08:38:35 -0700 (PDT) Sender: evanm@google.com Received: by 10.231.17.130 with HTTP; Sun, 27 Mar 2011 08:38:35 -0700 (PDT) In-Reply-To: References: Date: Sun, 27 Mar 2011 17:38:35 +0200 X-Google-Sender-Auth: TzqvHYVa6nrOE-wbu6YQce9ktiM Message-ID: From: Evan Martin To: "Y. A." Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true Cc: freebsd-chromium@freebsd.org Subject: Re: fixes for Makefile pkg-plist and build-in ffmpeg X-BeenThere: freebsd-chromium@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD-specific Chromium issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Mar 2011 15:38:40 -0000 On Sun, Mar 27, 2011 at 5:36 PM, Y. A. wrote: > +--- third_party/ffmpeg/ffmpeg.gyp.orig 2011-03-23 10:02:47.000000000 +02= 00 > ++++ third_party/ffmpeg/ffmpeg.gyp =A0 =A0 =A02011-03-27 15:07:20.0000000= 00 +0300 > +@@ -56,7 +56,7 @@ > + =A0 =A0 =A0 ['target_arch=3D=3D"arm"', { > + =A0 =A0 =A0 =A0 'ffmpeg_asm_lib': 0, > + =A0 =A0 =A0 }], > +- =A0 =A0 =A0['OS=3D=3D"mac" or OS=3D=3D"win"', { > ++ =A0 =A0 =A0['OS=3D=3D"mac" or OS=3D=3D"win" or OS=3D=3D"freebsd"', { > + =A0 =A0 =A0 =A0 'os_config%': '<(OS)', > + =A0 =A0 =A0 }, { =A0# all other Unix OS's use the linux config > + =A0 =A0 =A0 =A0 'os_config%': 'linux', > +@@ -82,7 +82,7 @@ I'd be happy to take a patch like this upstream if you think it's correct. If Linux is the special case, then perhaps simplifying the test to just 'OS!=3D"linux"' (and fixing the comment below) might be nice.