Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 29 Jan 2015 00:15:04 +0300
From:      Dmitry Marakasov <amdmi3@amdmi3.ru>
To:        freebsd-current@FreeBSD.org
Cc:        Warner Losh <imp@FreeBSD.org>, Nathan Whitehorn <nwhitehorn@freebsd.org>, Garrett Cooper <yaneurabeya@gmail.com>
Subject:   Re: OptionalObsoleteFiles.inc completeness improvement, try 2
Message-ID:  <20150128211504.GB55246@hades.panopticon>
In-Reply-To: <20150124002956.GI1101@hades.panopticon>
References:  <20150124002956.GI1101@hades.panopticon>

next in thread | previous in thread | raw e-mail | index | archive | help
* Dmitry Marakasov (amdmi3@amdmi3.ru) wrote:

The patch is complete, see https://reviews.freebsd.org/D1600.

- With it, for all knobs from src.conf(5) there are no difference in
  file tree contents between `KNOB make installworld` and `make
  installworld && KNOB make delete-old delete-old-libs`
- Note that some OLD_DIRS were removed - they were incorrect as most
  directories are installed unconditionally by mtree. Since empty
  directores are not really needed, the install process should be
  probably improved
- Some knobs which delete massive number of files (WITHOUT_MAN,
  WITHOUT_INCLUDES) were implemented with

  FILES!=find ...
  OLD_FILES+=${FILES}

  (similar construct was already used in WITHOUT_TESTS)

  I though of more effective implementation for this, such as
  introducing OLD_DIRS_RECURSIVE to fill from OptionalObsoleteFiles,
  in which delete-old will just call `find ... -delete`

- Unneeded conditions such as

  .if ${TARGET_ARCH} == "amd64" || ${TARGET_ARCH} == "powerpc64"
  OLD_FILES+=usr/lib32/...
  .else

  were not removed yet. Maybe with the next patch.

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150128211504.GB55246>