From owner-cvs-all@FreeBSD.ORG  Sat Apr  7 16:28:28 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 717F716A403;
	Sat,  7 Apr 2007 16:28:28 +0000 (UTC)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69])
	by mx1.freebsd.org (Postfix) with ESMTP id E275B13C48C;
	Sat,  7 Apr 2007 16:28:27 +0000 (UTC)
	(envelope-from ache@nagual.pp.ru)
Received: from nagual.pp.ru (ache@localhost [127.0.0.1])
	by nagual.pp.ru (8.13.8/8.13.8) with ESMTP id l37GSQ2x010206;
	Sat, 7 Apr 2007 20:28:26 +0400 (MSD)
	(envelope-from ache@nagual.pp.ru)
Received: (from ache@localhost)
	by nagual.pp.ru (8.13.8/8.13.8/Submit) id l37GSP9a010205;
	Sat, 7 Apr 2007 20:28:25 +0400 (MSD) (envelope-from ache)
Date: Sat, 7 Apr 2007 20:28:25 +0400
From: Andrey Chernov <ache@FreeBSD.org>
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
Message-ID: <20070407162825.GA10133@nagual.pp.ru>
Mail-Followup-To: Andrey Chernov <ache@freebsd.org>,
	Pawel Jakub Dawidek <pjd@FreeBSD.org>,
	Bruce Evans <bde@zeta.org.au>, src-committers@FreeBSD.org,
	cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
References: <200704052110.l35LAsXH013966@repoman.freebsd.org>
	<20070406115326.A43678@delplex.bde.org>
	<20070407160401.GI63916@garage.freebsd.pl>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="AhhlLboLdkugWU4S"
Content-Disposition: inline
In-Reply-To: <20070407160401.GI63916@garage.freebsd.pl>
User-Agent: Mutt/1.5.14 (2007-02-12)
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org,
	Bruce Evans <bde@zeta.org.au>
Subject: Re: cvs commit: src/include stdio.h src/lib/libc/sys lseek.2
	pathconf.2 src/sys/kern vfs_syscalls.c src/sys/sys filio.h unistd.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 07 Apr 2007 16:28:28 -0000


--AhhlLboLdkugWU4S
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Apr 07, 2007 at 06:04:01PM +0200, Pawel Jakub Dawidek wrote:
> Ok, I removed SEEK_DATA/SEEK_HOLE from stdio.h and hidden them in
> sys/unistd.h under:
>=20
> #if !defined(_POSIX_SOURCE) && !defined(_XOPEN_SOURCE)
> [...]
> #endif
>=20
> This is consistent which what Solaris has.

It is not enough. Currently you need !_C99_SOURCE !_ANSI_SOURCE=20
!_POSIX_C_SOURCE too (see the end of /sys/sys/cdefs.h)

BTW, we design our *_VISIBLE framework right for the reason to _not_=20
mention all possible *_SOURCE each time but mention one *_VISIBLE=20
tag instead, so please follow the rules how rest of our includes are made.

--=20
http://ache.pp.ru/

--AhhlLboLdkugWU4S
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.3 (FreeBSD)

iD8DBQFGF8aoVg5YK5ZEdN0RAkWLAJ9tK9y+MWYxovQmVq3igxeq6VaUugCgpGOw
HmEaOKxIJOZyBtdGIFZMey8=
=0Nrc
-----END PGP SIGNATURE-----

--AhhlLboLdkugWU4S--