Date: Fri, 14 Apr 2017 18:49:56 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: John Baldwin <jhb@freebsd.org> Cc: Ngie Cooper <ngie@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r316938 - head/sbin/savecore Message-ID: <201704150149.v3F1nu0D009274@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <1940104.87G28XVdqf@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Friday, April 14, 2017 07:41:48 PM Ngie Cooper wrote: > > Author: ngie > > Date: Fri Apr 14 19:41:48 2017 > > New Revision: 316938 > > URL: https://svnweb.freebsd.org/changeset/base/316938 > > > > Log: > > savecore: fix space calculation with respect to `minfree` in check_space(..) > > > > - Use strtoll(3) instead of atoi(3), because atoi(3) limits the > > representable data to INT_MAX. Check the values received from > > strtoll(3), trimming trailing whitespace off the end to maintain > > POLA. > > - Use `KiB` instead of `kB` when describing free space, total space, > > etc. I am now fully aware of `KiB` being the IEC standard for 1024 > > bytes and `kB` being the IEC standard for 1000 bytes. > > I will just rant lightly that no one actually uses this in the real world. > > Good lucking finding a "16 GiB" DIMM on crucial.com or a 4Kin drive. A > kilobyte is a power of 2. The End. > > (Next up we'll have to rename 4k displays to > 4k<insert arbitrary and unrelated letter here>) Do we use KiB, MiB, GiB,... any place else in the system? I cant think of a place we do this, so please, lets not start doing this here? Yes, these are newer standards, perhaps some day we should make a global switch to them, but lets not start mixing and matching things. > -- > John Baldwin -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201704150149.v3F1nu0D009274>