Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 2 Jan 2017 19:55:18 +0000 (UTC)
From:      Ngie Cooper <ngie@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r311133 - head/share/mk
Message-ID:  <201701021955.v02JtIh8067758@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: ngie
Date: Mon Jan  2 19:55:18 2017
New Revision: 311133
URL: https://svnweb.freebsd.org/changeset/base/311133

Log:
  Move the "MK_* options..." section before the "... MK_*_SUPPORT..." section
  
  For the case that someone set WITHOUT_GSSAPI=, now WITHOUT_KERBEROS_SUPPORT
  will be properly set.
  
  This will likely fix the issue for the default case noted in the PR I filed
  back in 2011. I am trying to fix the less obvious case documented in the PR
  still.
  
  MFC after:	2 weeks
  PR:		159745

Modified:
  head/share/mk/src.opts.mk

Modified: head/share/mk/src.opts.mk
==============================================================================
--- head/share/mk/src.opts.mk	Mon Jan  2 19:36:28 2017	(r311132)
+++ head/share/mk/src.opts.mk	Mon Jan  2 19:55:18 2017	(r311133)
@@ -402,6 +402,21 @@ MK_CLANG_FULL:= no
 .endif
 
 #
+# MK_* options whose default value depends on another option.
+#
+.for vv in \
+    GSSAPI/KERBEROS \
+    MAN_UTILS/MAN
+.if defined(WITH_${vv:H})
+MK_${vv:H}:=	yes
+.elif defined(WITHOUT_${vv:H})
+MK_${vv:H}:=	no
+.else
+MK_${vv:H}:=	${MK_${vv:T}}
+.endif
+.endfor
+
+#
 # Set defaults for the MK_*_SUPPORT variables.
 #
 
@@ -428,21 +443,6 @@ MK_${var}_SUPPORT:= yes
 .endif
 .endfor
 
-#
-# MK_* options whose default value depends on another option.
-#
-.for vv in \
-    GSSAPI/KERBEROS \
-    MAN_UTILS/MAN
-.if defined(WITH_${vv:H})
-MK_${vv:H}:=	yes
-.elif defined(WITHOUT_${vv:H})
-MK_${vv:H}:=	no
-.else
-MK_${vv:H}:=	${MK_${vv:T}}
-.endif
-.endfor
-
 .if !${COMPILER_FEATURES:Mc++11}
 MK_LLDB:=	no
 .endif



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201701021955.v02JtIh8067758>