Date: Tue, 28 Jun 2016 17:52:32 +0200 From: Hans Petter Selasky <hps@selasky.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: Slawa Olhovchenkov <slw@zxy.spb.ru>, ports@FreeBSD.org, FreeBSD Current <freebsd-current@freebsd.org> Subject: Re: pkg SAT_SOLVER bugs Message-ID: <0671148b-d7cd-f8ad-906d-a0baa1b98cf5@selasky.org> In-Reply-To: <20160627115533.gqvdsmtzwnvrrfuo@ivaldir.etoilebsd.net> References: <20150414200459.GE39658@ivaldir.etoilebsd.net> <20150421103454.GR1394@zxy.spb.ru> <5593D0AE.2010205@selasky.org> <416359ce-1dcd-1160-5c56-f120a0f6358f@selasky.org> <20160627115533.gqvdsmtzwnvrrfuo@ivaldir.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 06/27/16 13:55, Baptiste Daroussin wrote: > On Mon, Jun 27, 2016 at 12:38:02PM +0200, Hans Petter Selasky wrote: >> Hi, >> >> I found some bugs in PKG with regard to the SAT_SOLVER environment variable. >> Please find patch attached :-) >> >> Issues fixed: >> 1) No need to use hash table when generating SAT rules for external solver. >> Variables are already in a linear array. Fix encoding and decoding of SAT >> data. >> 2) Endless variable loop caused pkg to crash. >> 3) it->inverse was checked for non-zero, while it should actually be checked >> for -1 only. SAT rules produces were all negative. >> >> How to verify: >> >> make -C /usr/ports/math/picosat all install clean >> >> env SAT_SOLVER=picosat pkg upgrade >> >> --HPS > > Thank you I will look into shortly > Hi Baptiste, Are you handling this one or do you want me to create an issue at github. Thank you! --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0671148b-d7cd-f8ad-906d-a0baa1b98cf5>