From owner-freebsd-bugs@freebsd.org Thu Dec 1 14:10:01 2016 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 16F77C60825 for ; Thu, 1 Dec 2016 14:10:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 85BF01D22 for ; Thu, 1 Dec 2016 14:10:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id uB1EA06e065493 for ; Thu, 1 Dec 2016 14:10:00 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 214980] blacklistd and sshd incorrect counting of failed login attempts Date: Thu, 01 Dec 2016 14:10:00 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.0-STABLE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: azhegalov@gmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Dec 2016 14:10:01 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D214980 Bug ID: 214980 Summary: blacklistd and sshd incorrect counting of failed login attempts Product: Base System Version: 11.0-STABLE Hardware: amd64 OS: Any Status: New Severity: Affects Only Me Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: azhegalov@gmail.com CC: freebsd-amd64@FreeBSD.org CC: freebsd-amd64@FreeBSD.org Created attachment 177576 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D177576&action= =3Dedit some output from ssh, blacklistd and blacklistctl Every one failed ssh login attempt generates several counts in blacklistd.d= b. After two attempts ssh -b 10.10.0.1 test@192.168.4.75 Password for test@192.168.4.75: Password for test@192.168.4.75: i got: blacklistctl dump -a address/ma:port id nfail last access 10.10.0.1/32:22 OK 6/5 2016/12/01 16:55:48 And /usr/libexec/blacklistd-helper script does not check ipfw rule existence before adding it. It generates excess rules like: ipfw show 02022 27 2244 deny tcp from table(port22) to any dst-port 22 02022 0 0 deny tcp from table(port22) to any dst-port 22 <----- 02022 0 0 deny tcp from table(port22) to any dst-port 22 <----- 02022 0 0 deny tcp from table(port22) to any dst-port 22 <----- 65535 799979 77763414 allow ip from any to any --=20 You are receiving this mail because: You are the assignee for the bug.=