Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 30 Jun 1999 15:58:06 -0700 (PDT)
From:      Doug <Doug@gorean.org>
To:        sheldonh@FreeBSD.org
Cc:        freebsd-bugs@FreeBSD.org, freebsd-gnats-submit@FreeBSD.org
Subject:   Re: conf/12458: [Patch] 2 files not included by /usr/src/etc/Makefile
Message-ID:  <Pine.BSF.4.05.9906301546090.4384-100000@dt054n86.san.rr.com>
In-Reply-To: <199906302157.OAA65668@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 30 Jun 1999 sheldonh@FreeBSD.org wrote:

> Synopsis: [Patch] 2 files not included by /usr/src/etc/Makefile
> 
> State-Changed-From-To: open->feedback
> State-Changed-By: sheldonh
> State-Changed-When: Wed Jun 30 14:55:01 PDT 1999
> State-Changed-Why: 
> I worry that you haven't tested your changes,

	I have definitely tested my changes, and they definitely do what I
intended them to do. 

> since you've clearly
> overlooked the fact that we don't install a sysctl.conf, making your
> rc.sysctl a no-op.

	There are several files in /etc/ already that are no-op's unless
you activate the features that use them. In fact I dare say that half the
files in there are things I have never used, until recently when I started
using NFS. Now it's down to 1/3 of the files in /etc/ that I've never
used. 

> What are you hoping to achieve by adding these
> two files to the target?

	I think that the question you should ask is, "Why are these files
in /usr/src/etc/ if we're not going to install them?" At the same time,
what I hope to achieve is a complete update of the system configuration
files with mergemaster. I am more concerned about dhclient.conf
personally, but when I noticed that it wasn't getting installed I checked
the rest of the files in the directory and noticed the rc.sysctl file.
Personally I learned a lot about freebsd and what's available by reading
through the stuff in /etc as a new user, so as long as we are going to
provide that functionality in rc then we ought to slap the rc.sysctl file
in there to let people know about it. 

	Now that I've allayed your fears regarding my thought process, if
you're not comfortable with committing the patch, assign the PR to either
imp or obrien since they are the ones responsible for those two files.

Thanks,

Doug



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.05.9906301546090.4384-100000>