Date: Fri, 22 Aug 2014 17:49:24 +0000 (UTC) From: Jean-Sebastien Pedron <dumbbell@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r270343 - head/sys/dev/vt Message-ID: <201408221749.s7MHnOOZ067795@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: dumbbell Date: Fri Aug 22 17:49:24 2014 New Revision: 270343 URL: http://svnweb.freebsd.org/changeset/base/270343 Log: vt(4): Remove "FIXME" about multiple locking of vt_buf in vt_flush() After some testing, it appears that acquiring the lock once and keeping it longer is slower than taking it multiple times. While here, fix a typo in another comment. MFC after: 1 week Modified: head/sys/dev/vt/vt_core.c Modified: head/sys/dev/vt/vt_core.c ============================================================================== --- head/sys/dev/vt/vt_core.c Fri Aug 22 17:09:31 2014 (r270342) +++ head/sys/dev/vt/vt_core.c Fri Aug 22 17:49:24 2014 (r270343) @@ -428,7 +428,7 @@ vt_scroll(struct vt_window *vw, int offs diff = vthistory_seek(&vw->vw_buf, offset, whence); /* - * Offset changed, please update Nth lines on sceen. + * Offset changed, please update Nth lines on screen. * +N - Nth lines at top; * -N - Nth lines at bottom. */ @@ -903,12 +903,7 @@ vt_flush(struct vt_device *vd) !(vw->vw_flags & VWF_MOUSE_HIDE)) { /* Cursor displayed. */ if (vd->vd_moldx != vd->vd_mx || vd->vd_moldy != vd->vd_my) { - /* - * Mark last mouse position as dirty to erase. - * - * FIXME: The vt_buf lock is acquired twice in a - * row. - */ + /* Mark last mouse position as dirty to erase. */ vt_mark_mouse_position_as_dirty(vd, vd->vd_moldx, vd->vd_moldy);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201408221749.s7MHnOOZ067795>