From owner-svn-src-all@freebsd.org Fri Nov 3 19:21:37 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 92A2BE590F9; Fri, 3 Nov 2017 19:21:37 +0000 (UTC) (envelope-from mjg@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 60ED66FC12; Fri, 3 Nov 2017 19:21:37 +0000 (UTC) (envelope-from mjg@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id vA3JLaZw010002; Fri, 3 Nov 2017 19:21:36 GMT (envelope-from mjg@FreeBSD.org) Received: (from mjg@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id vA3JLakQ010001; Fri, 3 Nov 2017 19:21:36 GMT (envelope-from mjg@FreeBSD.org) Message-Id: <201711031921.vA3JLakQ010001@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: mjg set sender to mjg@FreeBSD.org using -f From: Mateusz Guzik Date: Fri, 3 Nov 2017 19:21:36 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r325368 - head/sys/kern X-SVN-Group: head X-SVN-Commit-Author: mjg X-SVN-Commit-Paths: head/sys/kern X-SVN-Commit-Revision: 325368 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Nov 2017 19:21:37 -0000 Author: mjg Date: Fri Nov 3 19:21:36 2017 New Revision: 325368 URL: https://svnweb.freebsd.org/changeset/base/325368 Log: Special-case pget lookups where pid == curproc->pid Saves on allproc_lock acquires during buildworld, poudriere etc. Submitted by: Pawel Biernacki Sponsored by: Mysterious Code Ltd. Differential Revision: D12929 Modified: head/sys/kern/kern_proc.c Modified: head/sys/kern/kern_proc.c ============================================================================== --- head/sys/kern/kern_proc.c Fri Nov 3 19:08:59 2017 (r325367) +++ head/sys/kern/kern_proc.c Fri Nov 3 19:21:36 2017 (r325368) @@ -389,23 +389,28 @@ pget(pid_t pid, int flags, struct proc **pp) struct proc *p; int error; - sx_slock(&allproc_lock); - if (pid <= PID_MAX) { - p = pfind_locked(pid); - if (p == NULL && (flags & PGET_NOTWEXIT) == 0) - p = zpfind_locked(pid); - } else if ((flags & PGET_NOTID) == 0) { - p = pfind_tid_locked(pid); + p = curproc; + if (p->p_pid == pid) { + PROC_LOCK(p); } else { - p = NULL; - } - sx_sunlock(&allproc_lock); - if (p == NULL) - return (ESRCH); - if ((flags & PGET_CANSEE) != 0) { - error = p_cansee(curthread, p); - if (error != 0) - goto errout; + sx_slock(&allproc_lock); + if (pid <= PID_MAX) { + p = pfind_locked(pid); + if (p == NULL && (flags & PGET_NOTWEXIT) == 0) + p = zpfind_locked(pid); + } else if ((flags & PGET_NOTID) == 0) { + p = pfind_tid_locked(pid); + } else { + p = NULL; + } + sx_sunlock(&allproc_lock); + if (p == NULL) + return (ESRCH); + if ((flags & PGET_CANSEE) != 0) { + error = p_cansee(curthread, p); + if (error != 0) + goto errout; + } } if ((flags & PGET_CANDEBUG) != 0) { error = p_candebug(curthread, p);