From owner-freebsd-toolchain@FreeBSD.ORG Mon May 20 23:02:15 2013 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 64DEB339; Mon, 20 May 2013 23:02:15 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pd0-f181.google.com (mail-pd0-f181.google.com [209.85.192.181]) by mx1.freebsd.org (Postfix) with ESMTP id 2A90EFB7; Mon, 20 May 2013 23:02:15 +0000 (UTC) Received: by mail-pd0-f181.google.com with SMTP id p11so5799489pdj.40 for ; Mon, 20 May 2013 16:02:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:subject:mime-version:content-type:from:in-reply-to:date :cc:content-transfer-encoding:message-id:references:to:x-mailer; bh=j87KbnicvUQrKa/YXIalOC1KFBc/5dk8/OkDUw8vVdA=; b=Low7gzo9eDS7kEmFKoErQ0SynZinjZuVMx9zyzXAaWFSt6xzDuH2q8u8raHD3DiEaN i1juGynBkBT2xjE9EzJMUMdESs9aQhzbRCMadLmSoFFGLqUkQ347aXXncPRHHsRaeFi3 HBIfNjQnDx1hdQh0fTNL6Hqavz/QSW5PR4MRXHYgLINOl83ixdSl/vzf7MOTcQztg6a6 Hu2g3NBx6BpD75DxHct3GkGi+wGP6AwhNKr0nGg2OnfHiyWeJcc6tgRP2+pCG8P7KSLx 3WKZ7TmWORWBjm3TG1LvI8tVJJiGBgQwrIN6YJbPQDch1jjCLAULI9KNVBXk3mC537Vt +WHQ== X-Received: by 10.68.236.70 with SMTP id us6mr40477260pbc.119.1369090934677; Mon, 20 May 2013 16:02:14 -0700 (PDT) Received: from [192.168.20.5] (c-98-203-241-95.hsd1.wa.comcast.net. [98.203.241.95]) by mx.google.com with ESMTPSA id gi2sm25838414pbb.2.2013.05.20.16.02.13 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 20 May 2013 16:02:13 -0700 (PDT) Subject: Re: svn commit: r250719 - in head: . usr.bin/make Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=us-ascii From: Garrett Cooper In-Reply-To: <201305162126.r4GLQk8Q021290@svn.freebsd.org> Date: Mon, 20 May 2013 16:02:11 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <4FEA9E51-475D-494C-83BB-9CBA90990770@gmail.com> References: <201305162126.r4GLQk8Q021290@svn.freebsd.org> To: Simon J. Gerraty X-Mailer: Apple Mail (2.1283) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, freebsd-toolchain@freebsd.org X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 May 2013 23:02:15 -0000 On May 16, 2013, at 2:26 PM, Simon J. Gerraty wrote: > Author: sjg > Date: Thu May 16 21:26:46 2013 > New Revision: 250719 > URL: http://svnweb.freebsd.org/changeset/base/250719 >=20 > Log: > Reverse the sense of the test wrt bmake, and guard against > MK_BMAKE not being defined. I forgot to request this earlier, but could you please document = bmake becoming the default system make in UPDATING and some of the = associated caveats? It's particularly important to note that set -e is = not being implicitly set on the command line (like before) and this is = going to potentially confuse some people as cd ; ${MAKE} was the pattern = that was done all over the place previously (like we discussed at YOW = after BSDCan, stuff where people weren't using set -e and were using = semicolons, needs to be fixed in Makefile, Makefile.inc1, etc in order = for builds to not silently fail as they will today). Thanks! -Garrett=