From owner-cvs-ports@FreeBSD.ORG Mon Feb 28 04:18:33 2011 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 61D8A1065673; Mon, 28 Feb 2011 04:18:33 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id E31398FC1D; Mon, 28 Feb 2011 04:18:32 +0000 (UTC) Received: by iyj12 with SMTP id 12so2922365iyj.13 for ; Sun, 27 Feb 2011 20:18:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:reply-to:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=/ehD4cCWS29aGKvS/TFRFah7vew25/MUkHicjIn7KIY=; b=MiiI6/xiJ82GPMzXxaIwhAZTZvtPinAX1wQV34CGteyjZLniNHpvitKYUXYvCmPRI9 ZXIrAoGlZ+FG5wa5afaqS1cHK7v5o3tT8rx/+eZO1QBYp7qwGKx9kyz3omUbKZcIZRgk ogLqaPZQsrTMzcRqqQwKXQKs2YOcl84CttKdA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; b=srtRfouS65YZRQ+DiRqwsAa6Y2ty5VVch248lo3tdHfhWEC8z4tbCBhSzPCa5mtuLn 63comOiQDppuRbqMy/a1c/f7Z4eQPYBW9oTNcuvRt3Y6U2BmMSOo5fA3gF4RZ2FtlMmM zV/zcjqSJ7YREV8Sfw7EO/OCXV5jZew7/7N7c= MIME-Version: 1.0 Received: by 10.231.40.10 with SMTP id i10mr5120395ibe.63.1298866712338; Sun, 27 Feb 2011 20:18:32 -0800 (PST) Received: by 10.231.194.37 with HTTP; Sun, 27 Feb 2011 20:18:32 -0800 (PST) In-Reply-To: <4D6AB7BD.2060203@FreeBSD.org> References: <201102271441.p1REfMrT016669@repoman.freebsd.org> <20110227193203.GA38353@magic.hamla.org> <4D6AB7BD.2060203@FreeBSD.org> Date: Mon, 28 Feb 2011 01:18:32 -0300 Message-ID: From: Marcelo Araujo To: Doug Barton Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: cvs-ports@freebsd.org, ports-committers@freebsd.org, cvs-all@freebsd.org, Sahil Tandon Subject: Re: cvs commit: ports/net/trafshow Makefile distinfo X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: araujo@FreeBSD.org List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Feb 2011 04:18:33 -0000 2011/2/27 Doug Barton > On 02/27/2011 11:32, Sahil Tandon wrote: > >> On Sun, 2011-02-27 at 14:41:22 +0000, Marcelo Araujo wrote: >> >> araujo 2011-02-27 14:41:22 UTC >>> >>> FreeBSD ports repository >>> >>> Modified files: >>> net/trafshow Makefile distinfo >>> Log: >>> - Now can build with supporting of IPV6. >>> - Removed MD5. >>> - Bump PORTREVISION. >>> >> >> If the IPv6 option is off by default (and thus, does not affect the >> default package), why do you bump PORTREVISION? I just want to >> understand for my own edification when dealing with similar situations. >> > > Sahil is right, if the change does not affect the package no bump is > needed. > > OTOH, my personal feeling is that we should default all IPV6 knobs to on. > :) > > > Well, I've used the latest paragraph that discribe when we should bump PORTREVISION. """A rule of thumb is to ask yourself whether a change committed to a port is something which someone, somewhere, would benefit from having (either because of an enhancement, fix, or by virtue that the new package will actually work for them). If yes, the PORTREVISION should be bumped so that automated tools (e.g. pkg_version) will highlight the fact that a new package is available.""" As the IPv6 option can be a good enhancement for trafshow, I decided to BUMP PORTREVISION. I believe in this case it is OK. If not, please someone else correct me. I'm gonna checking how the other ports dealing with IPv6 support, then I'm gonna check if it stay like now or put it by default ON. Best Regards, - Araujo