From owner-p4-projects  Wed Oct 30  7: 0:58 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 5103D37B404; Wed, 30 Oct 2002 07:00:56 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E0F5837B401
	for <perforce@freebsd.org>; Wed, 30 Oct 2002 07:00:55 -0800 (PST)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9BDD543E3B
	for <perforce@freebsd.org>; Wed, 30 Oct 2002 07:00:55 -0800 (PST)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id g9UExemV050335
	for <perforce@freebsd.org>; Wed, 30 Oct 2002 06:59:40 -0800 (PST)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.6/8.12.6/Submit) id g9UExeJV050329
	for perforce@freebsd.org; Wed, 30 Oct 2002 06:59:40 -0800 (PST)
Date: Wed, 30 Oct 2002 06:59:40 -0800 (PST)
Message-Id: <200210301459.g9UExeJV050329@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
Subject: PERFORCE change 20409 for review
To: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

http://perforce.freebsd.org/chv.cgi?CH=20409

Change 20409 by rwatson@rwatson_sproing on 2002/10/30 06:59:34

	The wonders of type checking: don't mix up structs mac, vnode, and
	label in transition entry points.

Affected files ...

.. //depot/projects/trustedbsd/mac/sys/security/mac_biba/mac_biba.c#169 edit

Differences ...

==== //depot/projects/trustedbsd/mac/sys/security/mac_biba/mac_biba.c#169 (text+ko) ====

@@ -1360,7 +1360,7 @@
 
 static void
 mac_biba_execve_transition(struct ucred *old, struct ucred *new,
-    struct vnode *vp, struct mac *vnodelabel, struct mac *shellvnodelabel,
+    struct vnode *vp, struct mac *vnodelabel, struct label *shellvnodelabel,
     struct image_params *imgp)
 {
 	struct mac_biba *source, *dest;
@@ -1374,7 +1374,7 @@
 
 static int
 mac_biba_execve_will_transition(struct ucred *old, struct vnode *vp,
-    struct mac *vnodelabel, struct vnode *shellvnodelabel,
+    struct label *vnodelabel, struct label *shellvnodelabel,
     struct image_params *imgp)
 {
 

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message