Date: Sun, 7 Apr 2002 08:38:01 +0400 From: "Andrey A. Chernov" <ache@nagual.pp.ru> To: Dag-Erling Smorgrav <des@ofug.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/sort init.c sort.c Message-ID: <20020407043800.GA62669@nagual.pp.ru> In-Reply-To: <xzpelhst9k5.fsf@flood.ping.uio.no> References: <200204070049.g370n1G28853@freefall.freebsd.org> <xzpelhst9k5.fsf@flood.ping.uio.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Apr 07, 2002 at 06:30:18 +0200, Dag-Erling Smorgrav wrote: > "Andrey A. Chernov" <ache@FreeBSD.org> writes: > > Log: > > Original code bugfixed. This NOT touch old sorting order a bit. > > > > 1) Remove \n from COPYRIGHT macro to shut up assembler warning > > 2) Fix struct sigaction initialization (arguments swap) > > 3) Fix out of bounds negative indexing for -R arg > 127 > > 4) Remove doubled initialization of vars already initialized statically > > 5) Convert ctype macros char arg to u_char to prevents sign extension > > Is there any reason why these patches could not first have been > contributed to NetBSD? Yes. Time limit. It was mark's idea to activate NetBSD sort by default, not mine. It should not be activated by my opinion. Once it is activated, I am in the time limit fixing its l10n because it is far more important in everyday sort's usage that having identical sorts. I can't work at the l10n fixes and be involved in the back contribute message exchange in the same time. At this moment I have some completely different approach about it, wait for the next my message. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020407043800.GA62669>