From owner-freebsd-bugs@FreeBSD.ORG Mon Sep 19 00:10:09 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 018AB1065674 for ; Mon, 19 Sep 2011 00:10:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D00178FC12 for ; Mon, 19 Sep 2011 00:10:08 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p8J0A8iA018482 for ; Mon, 19 Sep 2011 00:10:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p8J0A8AN018481; Mon, 19 Sep 2011 00:10:08 GMT (envelope-from gnats) Resent-Date: Mon, 19 Sep 2011 00:10:08 GMT Resent-Message-Id: <201109190010.p8J0A8AN018481@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Juergen Lock Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 548EC1065672 for ; Mon, 19 Sep 2011 00:09:57 +0000 (UTC) (envelope-from nox@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 439798FC0A for ; Mon, 19 Sep 2011 00:09:57 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p8J09v9h018443 for ; Mon, 19 Sep 2011 00:09:57 GMT (envelope-from nox@freefall.freebsd.org) Received: (from nox@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p8J09vhV018442; Mon, 19 Sep 2011 00:09:57 GMT (envelope-from nox) Message-Id: <201109190009.p8J09vhV018442@freefall.freebsd.org> Date: Mon, 19 Sep 2011 00:09:57 GMT From: Juergen Lock To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: kern/160815: [patch] [iwn] Fix channel switching in monitor mode X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Juergen Lock List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Sep 2011 00:10:09 -0000 >Number: 160815 >Category: kern >Synopsis: [patch] [iwn] Fix channel switching in monitor mode >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Sep 19 00:10:08 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Juergen Lock >Release: FreeBSD 8.2-STABLE i386 >Organization: me? organized?? >Environment: System: FreeBSD enceladus.kn-bremen.de 9.0-BETA1 FreeBSD 9.0-BETA1 #1: Thu Sep 15 23:06:39 CEST 2011 nox@enceladus.kn-bremen.de:/usr/obj/usr/src/sys/ENCELADUS amd64 >Description: As mentioned earler on -current, http://lists.freebsd.org/pipermail/freebsd-current/2011-September/027418.html I have a "Centrino Advanced-N 6230" half-size mini-pcie card and found channel switching didn't work in monitor mode, the patch below seems to fix it. >How-To-Repeat: # ifconfig wlan0 create wlandev iwn0 wlanmode monitor ... >Fix: --- src/sys/dev/iwn/if_iwn.c.orig +++ src/sys/dev/iwn/if_iwn.c @@ -6984,12 +6984,24 @@ iwn_set_channel(struct ieee80211com *ic) const struct ieee80211_channel *c = ic->ic_curchan; struct ifnet *ifp = ic->ic_ifp; struct iwn_softc *sc = ifp->if_softc; + int error; IWN_LOCK(sc); sc->sc_rxtap.wr_chan_freq = htole16(c->ic_freq); sc->sc_rxtap.wr_chan_flags = htole16(c->ic_flags); sc->sc_txtap.wt_chan_freq = htole16(c->ic_freq); sc->sc_txtap.wt_chan_flags = htole16(c->ic_flags); + + /* + * Only need to set the channel in Monitor mode. AP scanning and auth + * are already taken care of by their respective firmware commands. + */ + if (ic->ic_opmode == IEEE80211_M_MONITOR) { + error = iwn_config(sc); + if (error != 0) + device_printf(sc->sc_dev, + "error %d settting channel\n", error); + } IWN_UNLOCK(sc); } >Release-Note: >Audit-Trail: >Unformatted: