Date: Sat, 9 Jun 2018 08:13:03 +0200 From: Florian Smeets <flo@smeets.xyz> To: Eitan Adler <eadler@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334864 - head/usr.bin/top Message-ID: <06a78fe9-defe-d798-3764-4f1df521538f@smeets.xyz> In-Reply-To: <201806090214.w592EYsJ056425@repo.freebsd.org> References: <201806090214.w592EYsJ056425@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --P2tJ8mDTgA5xVypzdYBxCtdX7ETaLFQ1I Content-Type: multipart/mixed; boundary="Jf3QjLQwSiRLz32Dht9VZgi0AvsbV6ibs"; protected-headers="v1" From: Florian Smeets <flo@smeets.xyz> To: Eitan Adler <eadler@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <06a78fe9-defe-d798-3764-4f1df521538f@smeets.xyz> Subject: Re: svn commit: r334864 - head/usr.bin/top References: <201806090214.w592EYsJ056425@repo.freebsd.org> In-Reply-To: <201806090214.w592EYsJ056425@repo.freebsd.org> --Jf3QjLQwSiRLz32Dht9VZgi0AvsbV6ibs Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 09.06.18 04:14, Eitan Adler wrote: > Author: eadler > Date: Sat Jun 9 02:14:33 2018 > New Revision: 334864 > URL: https://svnweb.freebsd.org/changeset/base/334864 >=20 > Log: > top(1): use a different command to toggle tid vs pid Thank you. You cannot start top with -T unless you add something like the following:= Index: top.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- top.c (revision 334874) +++ top.c (working copy) @@ -328,7 +328,7 @@ optind =3D 1; } - while ((i =3D getopt(ac, av, "CSIHPabijJ:nquvzs:d:U:m:o:p:tw")) !=3D EO= F) + while ((i =3D getopt(ac, av, "CSIHPTabijJ:nquvzs:d:U:m:o:p:tw")) !=3D E= OF) { switch(i) { Another issue I just found is that if you start top with -P some columns don't show any values: CPU 0: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle CPU 1: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle CPU 2: % user, % nice, 1.2% system, % interrupt, 98.8% idle CPU 3: 0.4% user, % nice, 0.4% system, % interrupt, 99.2% idle CPU 4: % user, % nice, 0.4% system, % interrupt, 99.6% idle CPU 5: % user, % nice, 2.4% system, % interrupt, 97.6% idle CPU 6: % user, % nice, 0.4% system, % interrupt, 99.6% idle CPU 7: % user, % nice, 2.4% system, % interrupt, 97.6% idle It is correct if you start top with -TP or -HP, or if you start top -P and then use H or T to switch back and forth. I'm not sure in which revision this was broken, it works with r333899. Florian --Jf3QjLQwSiRLz32Dht9VZgi0AvsbV6ibs-- --P2tJ8mDTgA5xVypzdYBxCtdX7ETaLFQ1I Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEE7LNouHkIv7aRTXJp71uk3NWp88AFAlsbb/NfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEVD QjM2OEI4NzkwOEJGQjY5MTRENzI2OUVGNUJBNERDRDVBOUYzQzAACgkQ71uk3NWp 88BxBA/9Gq+HVWQaCiRHQBbKslyTZ9jPVw/XhQ6c5SZYvqTApb9PGxDnfJibpals eFq1Ks8rLEQF+Y+oBHHKrTO+VWUpFUM85HGSxrjHd4HLEhZCu8fu7Yn8vXkqvgL3 1jF2bTllYpaGR8U0z46Jvz54N+Kk1QVawExQGQsGknErGJom2CnstL/Qo+dsExjl ZuHY6seurORAsToijSa4nky8MvDcFQZMid5w7RVkcebbNZQiZ0jMxJQSx2qpQWwX RFBhsUekZ/ooxHtyabujjJLh8Fg3wP3B4bXRjQwmFo2j1CX6dWRNaZaD4ULzOqaX MLzHdpm9Nmvh4fzMScT02nbPG9x0YFZoHcyvmW80w08Y31Xn/rOLbEXUZbT2cXdu hddqk6rs8Lb/0udw0zu0tkHtIX7/s+IT0R08fzafumSVtZcoB3Mhh7EoUzKFyubO wtVVlPae4Gho32vPDZOejQSTXjW4k8QqmCrCfmLWXuVnS4R4Aa3098p4Xj2pKeWk Kvjl8dKOU8SloGDjCPuvc0FNXLMrmVxAISXdo6Y8y1FF8PZLH1ECw2pGu9JJYqcp pwdPiVvVQxCj5qb+62l07UViAuK0tX+uG9a2DNd+rd0S/7hLfox/D64PjuZzzrId 3FfjpcsI76jxzadj2wCMMyHZKUzYoE+R7KZVdvvnJJ5MYitpbSY= =m++y -----END PGP SIGNATURE----- --P2tJ8mDTgA5xVypzdYBxCtdX7ETaLFQ1I--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?06a78fe9-defe-d798-3764-4f1df521538f>