From owner-svn-src-head@freebsd.org Sat Jun 9 06:13:18 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1DAE91006EF4; Sat, 9 Jun 2018 06:13:18 +0000 (UTC) (envelope-from flo@smeets.xyz) Received: from mail-out.smeets.xyz (mail-out.smeets.xyz [5.9.17.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 564F7680D5; Sat, 9 Jun 2018 06:13:17 +0000 (UTC) (envelope-from flo@smeets.xyz) Received: from mail.smeets.xyz (mail6 [IPv6:2a01:4f8:160:918a::25:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mail-out.smeets.xyz (Postfix) with ESMTPS id D7BDF1960F7; Sat, 9 Jun 2018 08:13:09 +0200 (CEST) Received: from amavis.smeets.xyz (amavis.smeets.xyz [IPv6:2a01:4f8:160:918a::aa:4]) by mail.smeets.xyz (Postfix) with ESMTP id 963639CC6C; Sat, 9 Jun 2018 08:13:09 +0200 (CEST) X-Virus-Scanned: amavisd-new at smeets.xyz Received: from mail.smeets.xyz ([IPv6:2a01:4f8:160:918a::25:3]) by amavis.smeets.xyz (amavis.smeets.xyz [IPv6:2a01:4f8:160:918a::aa:4]) (amavisd-new, port 10025) with ESMTP id wHcfkbffSOaI; Sat, 9 Jun 2018 08:13:09 +0200 (CEST) Received: from nibbler-osx.fritz.box (p5DF5CD2D.dip0.t-ipconnect.de [93.245.205.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mail.smeets.xyz (Postfix) with ESMTPSA id A95789CC0A; Sat, 9 Jun 2018 08:13:08 +0200 (CEST) Subject: Re: svn commit: r334864 - head/usr.bin/top To: Eitan Adler , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201806090214.w592EYsJ056425@repo.freebsd.org> From: Florian Smeets Autocrypt: addr=flo@smeets.xyz; keydata= xsFNBFpyBwsBEADLq0c46orEtbMn4SptX+VJxR1wB4YwaErZme1bqF4nZHIhlRNET22HsHdQ doagaB4uACq0Rj5kHcu614ZnnNkLPyCxWQATx+cbdiFO4/hfT8tAvKnBtiy3awKJ5uGCNO2E zJwXW6KwdDA8XPRySqN8m1yPl+dW0Cls+/vO/QL/6+YLMupmEpSvFxRzAZTQuKyX4+xl+dYI d24JiPd1yfCuDNOY3+OZ3QBMT00u/699N8lUWRtiTwaQMwAOww8r/26YM6/SgcgFuLH2E/CV plY0sDvfoISlAj8agxdomNXfPjCMQ6w5yGZmA+huFpPCVBTi3on/SWgbQO7dLVpN4BNPuScP osCb/dsOg0S74zCClsIU3gdUGh9rwJY00/Ebid6V0R3c1Czwbg8LQedzlGDuXYXmzp6W2ujg r1cqbUD6lUWikUv2IMdCbb8MxYhHLi3GYUs5Xpi+W7vM6T45KbuMr7O/1SjtcGOlNeDvGNgj cDk20fOgPPZ+M6i9vX5Q2oI9HoYaeTiYNwILkBLVP/L40kTo5EkiQOt4OW6BMbylqXPOaQMW uGVbmhCJQpbx8Vo80s2yiBBVWkLkWQIcIm3KZlLldJqKEFpQBWLBE1eFFqboYgAWzFn73CaV 5tihobijMmmOV3a8cI1fI4kREyl3g+8bW+O0u3m3tuzVOpDpjwARAQABzR9GbG9yaWFuIFNt ZWV0cyA8ZmxvQHNtZWV0cy54eXo+wsGXBBMBCgBBAhsDBQkHhh+ABQsJCAcDBRUKCQgLBRYD AgEAAh4BAheAFiEE7LNouHkIv7aRTXJp71uk3NWp88AFAlpyB1gCGQEACgkQ71uk3NWp88DB 8RAAuwXf65kTtVwDAJEFnXQmRx8q/bfV5WWMVVZMM9zMOmLM006PlJlns9vDEwfXkUsTOKpC 9GEREdCVxsqQ/WqYrO0O8yLYRMY0IQ6w2B5cVzvf1DwY6Foc7zOpEgvAt5mCR9BoJ1eHf90K rHYUxf8AaWjJ/CE4EdN4wDvEY23tQ1ov0ReiNZokKfKKRF8rRbBhpwRcRyzV4eah3WvKKyOy PIGKquXG0GWhgty3rfNtion8AomFoQlK0lCq57okQj0HLS3vLTzXexvfWsLc+nLXT8eo87cl MQaYz7h5EjqM0r4FPRmGJ18nQ5wArt5vOf5oRv90RSH3QJLaxVdvt0BCDr2s1J5tTG7gZP/r Kyz9BrPtVvBwiHEW8jhw4lDbV3xIUEVkj4UEsM9XkHrHqd8JiFNZZOPE25VkuAeoeyB3j9km fZczF/f41cHp5v5RyTavta9QWA6Q07ARPu2JCBMMN+lJ9G/Ok8JlUgSGOwHZ+3R7jjvDMEFh 4DJhF2B77DdLxpLVJS0h5cS8WM6a/jm1Sk6DAi4bgksetvdyE/N/yxQmHokdKYW2LGDgd7cw dM2X660avFRe4ogZ0PeLRimPbyJuSN2+hZC/fy5jEv5PvZ+6spuwYMYDClefRpvBDqmCCxtf M1LNFRiXjdYvUdHvQ3facDzNpOkPLp0VexjJJ2HOwU0EWnIHCwEQANHrOm5vydK/ij1zkDyL Zzbogk5zjMh6oAr3cH4oGbJHPLlyFZTCVBYUwD4kh6NV1sKuZOeX/aygyVg1RyLulnzsc6Yj XOIxlqhqQwGI8k8ssAIpMSf029781CNF2HC42CrJeHtXNONDNOjsMuoxzga9zLQCh4jLTlE/ TUJo6KVABWBVRtTVh2Z77pKtN7j2NPFBHvp7K0WHfV+TYnlsgjhUA0ACZnUdHS2YRzBhCzzQ eludxBz54S9xbUq1mfZfVx8AbAGXF2zxo68nvvAAJn48HiBS3dMhCGYJDdZdja6QdUFPiemi nOxwkUzCqmKxm+Aj7USue1SbZZqJxmMI1eF4Ork/BJJI74Z/FnJgYR4UkEiD3J/KUocQCIH3 daB1+/CXlh99Ib7AP+QGuKk3vnNHh7VBq3E+VAiM5LU0BmgW+cdRPHkiwM7sDa2VnV3VqvV7 QmoMKnHFzUB6Nn8uE+iakp5J81Pr68kDOq7kLW3UnGmg1PUqbsnCaTimJb3JAYWzOW/9CYcP lbAdIqi+wH7MOoeL+PA99A3kW/881rGmeOYFzzrsNVLtea+AJfXtp4LN5gOVIPIpovCNSVXX EKgl7a4vjUGzVBzrH7PzT+k4XUEQwNCACfGZxEExtny19bjvumZ0rv+AEAHvsWSKXHUVJzIN jqd9UioaEbKGAPlPABEBAAHCwXwEGAEKACYWIQTss2i4eQi/tpFNcmnvW6Tc1anzwAUCWnIH CwIbDAUJB4YfgAAKCRDvW6Tc1anzwM/8D/9IbDzMvsz4O+Gcz1oUx4IMxbQDw99qgJexR5cj W207GkRnKVJ0zqx7Xc+U3AytniuwqHEXeV4qIqP6h14pEuCqdRJ+fSm65rB4+ZdeM2Y5YYvU BByOM78Mbs6SZy2k5X0EL5FXjNVIMOv2ImblyeRWhWK6gCfc/l7kV1EYVx9LV3umsc7K+ceZ lfE1U8hWbie8r7tl3V9ggF2g1cyc9ru0qW3sg8D4vNTS1uwdqeccKRc3osrVw4WrW1nGxTmT TCqVYGHjF2sANF9o1JB93hoXz8lydmDdhJ/62/XHapeT1FB8m7gulinM33VeOCCjN+dUgLQk 5tAGg+iHQWhC4Q/o4m0OqfdcSYdhCJ7h2I4GwOoGaxzoXqEL47Guxz+zE4osAFP5JLxCTbi2 x5sduCvxx3WbO95kZJKp7D0BIKpbKcfkyWse53YBI9wSrkIil+InnqvSDzU9nMvIyKSjv4ui wvZi1HY7tPiir/P2naZaiQ1SAM0KLP3g123WcnhRKo++ZRHhay5/70SKGdxEmKf3nld8xNCs 9EIWOTpRaqc9+zOcD1zVTZwnwgBrnPqzfPW9+d7FwAP1MdJbrROuC2bfzNZyoR4uHAnDOyNW wGSmShv7hhdettO8dJblneTY8vhzxo36pWmojEdgghXNw9Ji7kyInAmWq9kwV5Vou3ZNFw== Message-ID: <06a78fe9-defe-d798-3764-4f1df521538f@smeets.xyz> Date: Sat, 9 Jun 2018 08:13:03 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <201806090214.w592EYsJ056425@repo.freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="P2tJ8mDTgA5xVypzdYBxCtdX7ETaLFQ1I" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Jun 2018 06:13:18 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --P2tJ8mDTgA5xVypzdYBxCtdX7ETaLFQ1I Content-Type: multipart/mixed; boundary="Jf3QjLQwSiRLz32Dht9VZgi0AvsbV6ibs"; protected-headers="v1" From: Florian Smeets To: Eitan Adler , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <06a78fe9-defe-d798-3764-4f1df521538f@smeets.xyz> Subject: Re: svn commit: r334864 - head/usr.bin/top References: <201806090214.w592EYsJ056425@repo.freebsd.org> In-Reply-To: <201806090214.w592EYsJ056425@repo.freebsd.org> --Jf3QjLQwSiRLz32Dht9VZgi0AvsbV6ibs Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 09.06.18 04:14, Eitan Adler wrote: > Author: eadler > Date: Sat Jun 9 02:14:33 2018 > New Revision: 334864 > URL: https://svnweb.freebsd.org/changeset/base/334864 >=20 > Log: > top(1): use a different command to toggle tid vs pid Thank you. You cannot start top with -T unless you add something like the following:= Index: top.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- top.c (revision 334874) +++ top.c (working copy) @@ -328,7 +328,7 @@ optind =3D 1; } - while ((i =3D getopt(ac, av, "CSIHPabijJ:nquvzs:d:U:m:o:p:tw")) !=3D EO= F) + while ((i =3D getopt(ac, av, "CSIHPTabijJ:nquvzs:d:U:m:o:p:tw")) !=3D E= OF) { switch(i) { Another issue I just found is that if you start top with -P some columns don't show any values: CPU 0: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle CPU 1: 0.0% user, 0.0% nice, 0.0% system, 0.0% interrupt, 100% idle CPU 2: % user, % nice, 1.2% system, % interrupt, 98.8% idle CPU 3: 0.4% user, % nice, 0.4% system, % interrupt, 99.2% idle CPU 4: % user, % nice, 0.4% system, % interrupt, 99.6% idle CPU 5: % user, % nice, 2.4% system, % interrupt, 97.6% idle CPU 6: % user, % nice, 0.4% system, % interrupt, 99.6% idle CPU 7: % user, % nice, 2.4% system, % interrupt, 97.6% idle It is correct if you start top with -TP or -HP, or if you start top -P and then use H or T to switch back and forth. I'm not sure in which revision this was broken, it works with r333899. Florian --Jf3QjLQwSiRLz32Dht9VZgi0AvsbV6ibs-- --P2tJ8mDTgA5xVypzdYBxCtdX7ETaLFQ1I Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEE7LNouHkIv7aRTXJp71uk3NWp88AFAlsbb/NfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEVD QjM2OEI4NzkwOEJGQjY5MTRENzI2OUVGNUJBNERDRDVBOUYzQzAACgkQ71uk3NWp 88BxBA/9Gq+HVWQaCiRHQBbKslyTZ9jPVw/XhQ6c5SZYvqTApb9PGxDnfJibpals eFq1Ks8rLEQF+Y+oBHHKrTO+VWUpFUM85HGSxrjHd4HLEhZCu8fu7Yn8vXkqvgL3 1jF2bTllYpaGR8U0z46Jvz54N+Kk1QVawExQGQsGknErGJom2CnstL/Qo+dsExjl ZuHY6seurORAsToijSa4nky8MvDcFQZMid5w7RVkcebbNZQiZ0jMxJQSx2qpQWwX RFBhsUekZ/ooxHtyabujjJLh8Fg3wP3B4bXRjQwmFo2j1CX6dWRNaZaD4ULzOqaX MLzHdpm9Nmvh4fzMScT02nbPG9x0YFZoHcyvmW80w08Y31Xn/rOLbEXUZbT2cXdu hddqk6rs8Lb/0udw0zu0tkHtIX7/s+IT0R08fzafumSVtZcoB3Mhh7EoUzKFyubO wtVVlPae4Gho32vPDZOejQSTXjW4k8QqmCrCfmLWXuVnS4R4Aa3098p4Xj2pKeWk Kvjl8dKOU8SloGDjCPuvc0FNXLMrmVxAISXdo6Y8y1FF8PZLH1ECw2pGu9JJYqcp pwdPiVvVQxCj5qb+62l07UViAuK0tX+uG9a2DNd+rd0S/7hLfox/D64PjuZzzrId 3FfjpcsI76jxzadj2wCMMyHZKUzYoE+R7KZVdvvnJJ5MYitpbSY= =m++y -----END PGP SIGNATURE----- --P2tJ8mDTgA5xVypzdYBxCtdX7ETaLFQ1I--