Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 11 Jul 2015 10:33:10 -0400
From:      Craig Rodrigues <rodrigc@crodrigues.org>
To:        John-Mark Gurney <jmg@funkthat.com>
Cc:        "src-committers@freebsd.org" <src-committers@freebsd.org>,  "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,  "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r285366 - in head: lib/libmd sys/crypto/sha2
Message-ID:  <CAG=rPVcva-GOLsSbbVOPWssP1SB=hAPwyib73ARUwED0skDX5g@mail.gmail.com>
In-Reply-To: <20150711142920.GE8523@funkthat.com>
References:  <201507110312.t6B3CZBv081280@repo.freebsd.org> <20150711080439.GD8523@funkthat.com> <CAG=rPVcCSzHKwqyOzAZOG=N9pBMpwFbY%2BCMOM655BanjnNVQ-w@mail.gmail.com> <20150711142920.GE8523@funkthat.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jul 11, 2015 at 10:29 AM, John-Mark Gurney <jmg@funkthat.com> wrote:

> Craig Rodrigues wrote this message on Sat, Jul 11, 2015 at 10:16 -0400:
>
> > So it looks like _libmd_SHA256_File is not defined in the legacy
> > library used during the bootstrap.
>
> The closest I can see is that sha256hl.c (from mdXhl.c) is including
> "sha256.h" with double quotes, and getting the wrong header file..
>
>
Yes, I think you are right.

If I go to src/lib/libmd, and type:

make -V CFLAGS

I see:

-O2 -pipe   -I/builds/FreeBSD_HEAD/lib/libmd -DWEAK_REFS -std=gnu99
-Qunused-arguments  -fstack-protector -Wno-pointer-sign -Wno-empty-body
-Wno-string-plus-int -Wno-unused-const-variable -Wno-tautological-compare
-Wno-unused-value -Wno-parentheses-equality -Wno-unused-function
-Wno-enum-conversion -Wno-switch -Wno-switch-enum
-Wno-knr-promoted-parameter -Wno-parentheses

After your change, there is no sha256.h file in the src/lib/libmd
directory, so the bootstrap stage
is picking up sha256.h from /usr/include , which causes problems.
--
Craig



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG=rPVcva-GOLsSbbVOPWssP1SB=hAPwyib73ARUwED0skDX5g>