From owner-freebsd-bugs  Tue Jun 27  8:30: 7 2000
Delivered-To: freebsd-bugs@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by hub.freebsd.org (Postfix) with ESMTP id 6DAE637C210
	for <freebsd-bugs@FreeBSD.org>; Tue, 27 Jun 2000 08:30:03 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id IAA19624;
	Tue, 27 Jun 2000 08:30:03 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Date: Tue, 27 Jun 2000 08:30:03 -0700 (PDT)
Message-Id: <200006271530.IAA19624@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>
Subject: kern/19535: procfs_rlimit tidyup
Reply-To: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

The following reply was made to PR kern/19535; it has been noted by GNATS.

From: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>
To: adrian@vader.creative.net.au
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: kern/19535: procfs_rlimit tidyup
Date: Tue, 27 Jun 2000 11:29:22 -0400 (EDT)

 <<On Mon, 26 Jun 2000 23:12:45 +0200 (CEST), adrian@FreeBSD.ORG said:
 
 > +	psbuf = (char *)malloc(512 * sizeof(char), M_TEMP, M_WAITOK);
 
 sizeof(char) is defined to be 1.
 
 > +		/* XXX conservative, but potentially overflowable */
 
 It should be possible to compute the exact buffer size.  Since this
 code is not frequently run, I would suggest that a two-pass approach
 would not hurt.
 
 
 -GAWollman
 
 


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message