From owner-freebsd-net@FreeBSD.ORG Fri Aug 1 18:18:27 2014 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id C07FD176 for ; Fri, 1 Aug 2014 18:18:27 +0000 (UTC) Received: from mail-qa0-x229.google.com (mail-qa0-x229.google.com [IPv6:2607:f8b0:400d:c00::229]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8097F2269 for ; Fri, 1 Aug 2014 18:18:27 +0000 (UTC) Received: by mail-qa0-f41.google.com with SMTP id j7so4390530qaq.28 for ; Fri, 01 Aug 2014 11:18:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=NlFb9yjHK7ED2cfMyRsgOTReSpqiy+yJOKSuA6i6Lso=; b=IOpnU2wX3uyj/oWFvJGLzIa/r3rRp+u8XWedotmomzg1kRLp75y/l2pXZbBcbCNIJP NlpThiK9qfxLyxHS8uv3shoXFsa5cQjEu0LMDq9FnTROIjuU5EMe2tfqk/7WvRSJez6F 0odTLqG4+1xq7dGqh+HCWFeraZQiQmNyzRgBmiqknk8GQt1lnAQJ+3NB5dAzawkjS/14 kDpzTZDEk1zjFaHX095Q9qgd5EzGkfTheR2HgBUHrrjCea8pkmvqQOk4RQg37ajufN1j uXxGWaT1JvzWAgffYQQ3vJW9ASpa8//e0vTQI/PMEFqx04P+GNgL842R6OHxFoHd9Zr4 euGg== MIME-Version: 1.0 X-Received: by 10.224.55.131 with SMTP id u3mr11734857qag.98.1406917106397; Fri, 01 Aug 2014 11:18:26 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.224.1.6 with HTTP; Fri, 1 Aug 2014 11:18:26 -0700 (PDT) In-Reply-To: <20140801153744.GA76021@gmail.com> References: <20140630170453.GA21404@gmail.com> <20140630205359.GA2221@gmail.com> <20140801141920.GC75551@gmail.com> <20140801153744.GA76021@gmail.com> Date: Fri, 1 Aug 2014 11:18:26 -0700 X-Google-Sender-Auth: FP4LM9dvWGGIXe1M1dhzpxcN234 Message-ID: Subject: Re: [PATCH] Implementation of draft-ietf-tcpm-newcwv-06 From: Adrian Chadd To: Tom Jones Content-Type: text/plain; charset=UTF-8 Cc: FreeBSD Net X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Aug 2014 18:18:27 -0000 Hi! This is looking better! Structurally though, I'd look at all those places where you only update tp->newcv and instead of passing in the tp, pass in a pointer to tp->newcv. That way you're keeping a lid on the scope of the helper functions - they only get access to as much data as they need so you later won't be tempted to do things like go "oh, I just need to get access to this one tcpcb field!" and suddenly it's not so well contained. As for behavioural - I think you'll have to poke Robert or Lawrence a little more just to get some feedback from them. It's good that it's disabled-by-default for now - that lets it get into -HEAD with a lack of surprise. Thanks for doing this! -a