Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 2 Aug 2015 22:58:17 -0700
From:      Adrian Chadd <adrian.chadd@gmail.com>
To:        Baptiste Daroussin <bapt@freebsd.org>
Cc:        "src-committers@freebsd.org" <src-committers@freebsd.org>,  "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,  "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r286211 - head/usr.sbin/pw
Message-ID:  <CAJ-VmomNaeVaiOZqhuSC2Okwc0jiGpeq63M24h2dU%2B9jeO3%2B2A@mail.gmail.com>
In-Reply-To: <201508021949.t72JnO2U011079@repo.freebsd.org>
References:  <201508021949.t72JnO2U011079@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
pw is still broken, compiling mips:

cc1: warnings being treated as errors
/usr/home/adrian/work/freebsd/head-embedded-2/src/usr.sbin/pw/pw_user.c:
In function 'pw_user_next':
/usr/home/adrian/work/freebsd/head-embedded-2/src/usr.sbin/pw/pw_user.c:680:
warning: statement with no effect
/usr/home/adrian/work/freebsd/head-embedded-2/src/usr.sbin/pw/pw_user.c:
In function 'pw_user_show':
/usr/home/adrian/work/freebsd/head-embedded-2/src/usr.sbin/pw/pw_user.c:758:
warning: comparison of unsigned expression < 0 is always false
/usr/home/adrian/work/freebsd/head-embedded-2/src/usr.sbin/pw/pw_user.c:
In function 'pw_user_del':
/usr/home/adrian/work/freebsd/head-embedded-2/src/usr.sbin/pw/pw_user.c:831:
warning: comparison of unsigned expression < 0 is always false
/usr/home/adrian/work/freebsd/head-embedded-2/src/usr.sbin/pw/pw_user.c:
In function 'pw_user_mod':
/usr/home/adrian/work/freebsd/head-embedded-2/src/usr.sbin/pw/pw_user.c:1433:
warning: suggest parentheses around assignment used as truth value
--- pw_user.o ---

.. tsk bapt! I'm on holiday and I can't build -head. :(


-a


On 2 August 2015 at 12:49, Baptiste Daroussin <bapt@freebsd.org> wrote:
> Author: bapt
> Date: Sun Aug  2 19:49:24 2015
> New Revision: 286211
> URL: https://svnweb.freebsd.org/changeset/base/286211
>
> Log:
>   Use intmax_t rather than long long
>
> Modified:
>   head/usr.sbin/pw/pw_conf.c
>
> Modified: head/usr.sbin/pw/pw_conf.c
> ==============================================================================
> --- head/usr.sbin/pw/pw_conf.c  Sun Aug  2 18:20:36 2015        (r286210)
> +++ head/usr.sbin/pw/pw_conf.c  Sun Aug  2 19:49:24 2015        (r286211)
> @@ -493,11 +493,11 @@ write_userconfig(struct userconf *cnf, c
>                         quote = 0;
>                         break;
>                 case _UC_EXPIRE:
> -                       sbuf_printf(buf, "%lld", (long long)cnf->expire_days);
> +                       sbuf_printf(buf, "%jd", (intmax_t)cnf->expire_days);
>                         quote = 0;
>                         break;
>                 case _UC_PASSWORD:
> -                       sbuf_printf(buf, "%lld", (long long)cnf->password_days);
> +                       sbuf_printf(buf, "%jd", (intmax_t)cnf->password_days);
>                         quote = 0;
>                         break;
>                 case _UC_NONE:
>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmomNaeVaiOZqhuSC2Okwc0jiGpeq63M24h2dU%2B9jeO3%2B2A>