From owner-svn-src-head@freebsd.org Mon Aug 3 05:58:18 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EFB1C99C111; Mon, 3 Aug 2015 05:58:17 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-io0-x229.google.com (mail-io0-x229.google.com [IPv6:2607:f8b0:4001:c06::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BE33C100F; Mon, 3 Aug 2015 05:58:17 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by iodd187 with SMTP id d187so134722190iod.2; Sun, 02 Aug 2015 22:58:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=zj6zIW44ciMGgZpDGlP3u7XU/JzvAfYC20gr70xmwlc=; b=lSgNqSPEOCR6d503ZsaFlEykWJK5xgr1n8lmf2ZnpA7iGUMGnI1+Tkp1y89q6GT6BM qDwTA3D8C0lpvn85oG+L+OLzbgDPweXkL8OW0Q7BQPgCtpvjN6nEmkauU5inTJhLdgs0 47788NuZ3e0DvIM8aSKMuio+hPY5qiYR21ijZ5GAZtqPgg8WTza5uq8bLrB/C9tw0jJF vIjVc969WIwTdAMt3RTe0U3Rig9Ik7Ub49llPOblNnQKOVdQR9OZB0578hSkqhCnxZ7U 7VnPN1hcH1rwVBqltV+ZMSqDW9xf8/9rHMvs1glRhFkpaacNKvV04kIZWp3jC2hSmMZa 3tbQ== MIME-Version: 1.0 X-Received: by 10.107.169.138 with SMTP id f10mr17617355ioj.75.1438581497205; Sun, 02 Aug 2015 22:58:17 -0700 (PDT) Received: by 10.36.38.133 with HTTP; Sun, 2 Aug 2015 22:58:17 -0700 (PDT) In-Reply-To: <201508021949.t72JnO2U011079@repo.freebsd.org> References: <201508021949.t72JnO2U011079@repo.freebsd.org> Date: Sun, 2 Aug 2015 22:58:17 -0700 Message-ID: Subject: Re: svn commit: r286211 - head/usr.sbin/pw From: Adrian Chadd To: Baptiste Daroussin Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Aug 2015 05:58:18 -0000 pw is still broken, compiling mips: cc1: warnings being treated as errors /usr/home/adrian/work/freebsd/head-embedded-2/src/usr.sbin/pw/pw_user.c: In function 'pw_user_next': /usr/home/adrian/work/freebsd/head-embedded-2/src/usr.sbin/pw/pw_user.c:680: warning: statement with no effect /usr/home/adrian/work/freebsd/head-embedded-2/src/usr.sbin/pw/pw_user.c: In function 'pw_user_show': /usr/home/adrian/work/freebsd/head-embedded-2/src/usr.sbin/pw/pw_user.c:758: warning: comparison of unsigned expression < 0 is always false /usr/home/adrian/work/freebsd/head-embedded-2/src/usr.sbin/pw/pw_user.c: In function 'pw_user_del': /usr/home/adrian/work/freebsd/head-embedded-2/src/usr.sbin/pw/pw_user.c:831: warning: comparison of unsigned expression < 0 is always false /usr/home/adrian/work/freebsd/head-embedded-2/src/usr.sbin/pw/pw_user.c: In function 'pw_user_mod': /usr/home/adrian/work/freebsd/head-embedded-2/src/usr.sbin/pw/pw_user.c:1433: warning: suggest parentheses around assignment used as truth value --- pw_user.o --- .. tsk bapt! I'm on holiday and I can't build -head. :( -a On 2 August 2015 at 12:49, Baptiste Daroussin wrote: > Author: bapt > Date: Sun Aug 2 19:49:24 2015 > New Revision: 286211 > URL: https://svnweb.freebsd.org/changeset/base/286211 > > Log: > Use intmax_t rather than long long > > Modified: > head/usr.sbin/pw/pw_conf.c > > Modified: head/usr.sbin/pw/pw_conf.c > ============================================================================== > --- head/usr.sbin/pw/pw_conf.c Sun Aug 2 18:20:36 2015 (r286210) > +++ head/usr.sbin/pw/pw_conf.c Sun Aug 2 19:49:24 2015 (r286211) > @@ -493,11 +493,11 @@ write_userconfig(struct userconf *cnf, c > quote = 0; > break; > case _UC_EXPIRE: > - sbuf_printf(buf, "%lld", (long long)cnf->expire_days); > + sbuf_printf(buf, "%jd", (intmax_t)cnf->expire_days); > quote = 0; > break; > case _UC_PASSWORD: > - sbuf_printf(buf, "%lld", (long long)cnf->password_days); > + sbuf_printf(buf, "%jd", (intmax_t)cnf->password_days); > quote = 0; > break; > case _UC_NONE: >