Date: Wed, 27 Jan 1999 23:20:01 -0800 (PST) From: dcs@newsguy.com To: freebsd-bugs@FreeBSD.ORG Subject: kern/9412 wasn't quite on the mark... Message-ID: <199901280720.XAA99195@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/9412; it has been noted by GNATS.
From: dcs@newsguy.com
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: kern/9412 wasn't quite on the mark...
Date: Thu, 28 Jan 1999 16:09:23 +0900 (JST)
>Submitter-Id: current-users
>Originator: Daniel C. Sobral
>Organization:
>Confidential: no
>Synopsis: ficlExecFD wasn't modified to deal with changes in kern/9412
>Severity: serious
>Priority: medium
>Category: bin
>Release: FreeBSD 4.0-CURRENT i386
>Class: sw-bug
>Environment:
Current since kern/9412 (EXCEPTION word set) got in.
>Description:
It turns out a bug I was blaming on ficl was actually my fault.
When EXCEPTION word set got in, the ordering of the VM_* results was
changed, to conform with ANS Forth standard. Unfortunately, ficlExecFD
depended on that ordering, and didn't get modified.
Say... about these pointy hats... are they committers' only?
'cause I think I'll be needing a load of them... (see next (or previous,
depending how they get queued) PR...)
>How-To-Repeat:
cp /usr/share/examples/bootforth/* /boot
reboot
>Fix:
Apply the following fix:
--- src/sys/boot/ficl/ficl.c 1999/01/25 04:37:06 1.7
+++ src/sys/boot/ficl/ficl.c 1999/01/28 06:34:10
@@ -374,7 +374,8 @@
break;
continue;
}
- if ((rval = ficlExec(pVM, cp, i)) >= VM_ERREXIT)
+ rval = ficlExec(pVM, cp, i);
+ if(rval != VM_QUIT && rval != VM_USEREXIT && rval != VM_OUTOFTEXT)
{
pVM->sourceID = id;
vmThrowErr(pVM, "ficlExecFD: Error at line %d", nLine);
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199901280720.XAA99195>