Date: Wed, 19 Aug 1998 23:50:01 -0700 (PDT) From: Max Gotlib <max@cca.usart.ru> To: freebsd-bugs@FreeBSD.ORG Subject: Re: kern/7144: WaveLAN interface moves packets to uper layer while dst addr does not belong to that interface (even while not in allmulti/promisc mode) Message-ID: <199808200650.XAA00316@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/7144; it has been noted by GNATS.
From: Max Gotlib <max@cca.usart.ru>
To: Greg Troxel <gdt@ir.bbn.com>
Cc: freebsd-gnats-submit@freebsd.org, Jim Binkley <jrb@cs.pdx.edu>,
Mike Smith <mike@smith.net.au>
Subject: Re: kern/7144: WaveLAN interface moves packets to uper layer while dst addr does not belong to that interface (even while not in allmulti/promisc mode)
Date: Thu, 20 Aug 1998 12:55:39 +0600 (ESD)
Hi!
Glad too see that wavelan technology is of a particular interest ...
And as for suggested patch - totally agreed :)))
And one Q. more - I sent another patch (kern/7044) that fixed
(at least for me) wavelan board initialization process...
Can you test it on your board, please, and if the results
will be successfull - i would be glad to see it (or it's variant)
in the FreeBSD source tree...
With best regards,
Max.
On Wed, 19 Aug 1998, Greg Troxel wrote:
> I had just about the same problem, with 915 MHz ISA wavelans cards and
> no wavepoints. Running mrouted, which set IFF_ALLMULTI caused unicast
> packets with a mac address not matching the local machine to be
> forwarded. My fix is different, and I believe makes bpf work
> correctly.
>
> The check for dropping unicast packets not sent to our ethernet
> address is after the bpf tap, but not conditioned on it. All packets
> received should get handed to bpf, and unicast packets not to us (mac)
> should get dropped whether or not there is a bpf listener. I believe
> that the common optimization that the interface is in hw promisc mode
> iff there is a bpf listener is in general wrong, but more frequently
> so on wavelans.
>
> I think Max's fix makes bpf listeners not see unicast packets sent to
> others, but I'm not sure.
>
> One can argue that checking on MOD_ENAL is wrong, but the code only
> drops packets that shouldn't be received. The correctness condition
> is that it be run whenever unicast packets without our mac address can
> be received.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199808200650.XAA00316>