Date: Thu, 14 May 2015 10:10:12 -0600 From: Adam Weinberger <adamw@adamw.org> To: Bryan Drewery <bdrewery@FreeBSD.org> Cc: "Philip M. Gollucci" <pgollucci@p6m7g8.com>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org> Subject: Re: svn commit: r386285 - head/security/keychain Message-ID: <317F946C-1F0E-4F8E-B121-6442CC82BCAA@adamw.org> In-Reply-To: <5554C8A1.50200@FreeBSD.org> References: <201505140101.t4E11r9T031351@svn.freebsd.org> <08F806A7-3CD9-417A-BA4E-AF739E83B6A8@adamw.org> <CACM2dAaFL6F-=mbfODTRrR83L%2BGeLfxzcM16DoroP1shmP6NHQ@mail.gmail.com> <082DB80D-6385-4F4F-8A86-2DB4561E39E8@adamw.org> <5554C761.3060609@FreeBSD.org> <07ED759D-DFAC-44D0-A22B-1639EE3E0CB8@adamw.org> <5554C8A1.50200@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 14 May, 2015, at 10:09, Bryan Drewery <bdrewery@FreeBSD.org> wrote: >=20 > On 5/14/2015 11:07 AM, Adam Weinberger wrote: >>> On 14 May, 2015, at 10:03, Bryan Drewery <bdrewery@FreeBSD.org> = wrote: >>>=20 >>> On 5/14/2015 11:00 AM, Adam Weinberger wrote: >>>>> On 13 May, 2015, at 21:20, Philip M. Gollucci = <pgollucci@p6m7g8.com> wrote: >>>>>=20 >>>>> Then it needs an option not an if exists() >>>>=20 >>>> Bryan, can you please consider reverting it, or giving me approval = to revert it? It may fix the case when the port is built in poudriere = without sshd in base, but it is a regression for everybody else. >>>>=20 >>>> # Adam >>>>=20 >>>>=20 >>>=20 >>> No. The way RUN_DEPENDS is supposed to work is what I said in the >>> commit. These exists() checks are redundant and confuse the package >>> dependencies. >>>=20 >>> How are you building? It's possible the tool you are using is >>> incorrectly handling RUN_DEPENDS. >>=20 >> Ah! I see. It's portmaster that's doing the misbehaving. The problem = is that openssh-portable still shows up in run-depends-list, and so = portmaster decides that it is going to install openssh-portable first. >>=20 >> [root@apnoea /usr/ports/security/keychain] which ssh-agent >> /usr/bin/ssh-agent >> [root@apnoea /usr/ports/security/keychain] make run-depends-list >> /usr/ports/security/openssh-portable >> /usr/ports/shells/bash >>=20 >=20 > Ok. I'll look at portmaster and try to fix it now. We really need = these > exists() to go away; it causes rebuilds on the package cluster for no > reason. This specific case is not one, but we need them to generally = go > away. Sorry about the noise, Bryan. # Adam --=20 Adam Weinberger adamw@adamw.org http://www.adamw.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?317F946C-1F0E-4F8E-B121-6442CC82BCAA>