From owner-svn-src-all@freebsd.org Wed Mar 8 06:48:10 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 19631D02F3D; Wed, 8 Mar 2017 06:48:10 +0000 (UTC) (envelope-from decui@microsoft.com) Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0113.outbound.protection.outlook.com [104.47.42.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT SSL SHA2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BF8F9133D; Wed, 8 Mar 2017 06:48:08 +0000 (UTC) (envelope-from decui@microsoft.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=kk4S0hBCZWuQgJ3PloEbBwRYOcVceewjfWDs+KWjAaA=; b=AVvV5yi1X8/1XN+t6BzDZBWC/6ser3ij9hywXRg5GQMmwPYmgVeNsJ4+r4r2EpduGf8XxB6WBKJDOb6N7JXOxmptFXyH24rWg9Pc5XEftNQUupfM6SPKod+6AckcpnuVRz7Z71tExXgKuI4WGnNH+1LNAcuhlyO7a6fNlz98cQs= Received: from MWHPR03MB2669.namprd03.prod.outlook.com (10.168.207.15) by MWHPR03MB2670.namprd03.prod.outlook.com (10.168.207.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.947.12; Wed, 8 Mar 2017 06:48:08 +0000 Received: from MWHPR03MB2669.namprd03.prod.outlook.com ([10.168.207.15]) by MWHPR03MB2669.namprd03.prod.outlook.com ([10.168.207.15]) with mapi id 15.01.0947.020; Wed, 8 Mar 2017 06:48:08 +0000 From: Dexuan Cui To: "rgrimes@freebsd.org" CC: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: RE: svn commit: r314891 - head/sys/boot/efi/loader Thread-Topic: svn commit: r314891 - head/sys/boot/efi/loader Thread-Index: AQHSl8UgOJUfutct6Uqb4OiSfnjftqGKfjYA Date: Wed, 8 Mar 2017 06:48:07 +0000 Message-ID: References: <201703080250.v282oTDF096183@repo.freebsd.org> <201703080433.v284XICJ098481@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201703080433.v284XICJ098481@pdx.rh.CN85.dnsmgr.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: freebsd.org; dkim=none (message not signed) header.d=none;freebsd.org; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [2404:f801:9000:19::4a9] x-ms-office365-filtering-correlation-id: e97f676f-faf1-45db-dd32-08d465ef146b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(48565401081); SRVR:MWHPR03MB2670; x-microsoft-exchange-diagnostics: 1; MWHPR03MB2670; 7:rJZAAluzfk3tbrMB6L5jZjKBlToU9eAu6mfiCVZOKZP9qJuZzbFdme84Al46btyOUhSG14QnN8rfxtKML4mZjaGV4QIlUul9vWft+pjvKLj1PwuRgCBwLYL3b5Gm6WAuFx74q1cIqCXJPm0vrtIsEWJBO7roIRkwm3UDy+11ocd7g/+jjC0wzrEFhKVrS4uF0umxex0uaDbiplQrqCaIepKYv2gA+OuRnGxfQvUB01AnfqV5AjMU5gjf0TxWhDnYX1vBjYLNcOL+EkMZYVJxdi1+pjDJbDGFRNJAqSFxFaZuN0UyiV71W3M4mS7GZVp373uzZOi/ePBbzFfobRyrU6379r0LC9jwkVnQM86Npas= x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(61425038)(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026)(61426038)(61427038)(6041248)(20161123562025)(20161123564025)(20161123555025)(20161123560025)(20161123558025)(6072148); SRVR:MWHPR03MB2670; BCL:0; PCL:0; RULEID:; SRVR:MWHPR03MB2670; x-forefront-prvs: 02408926C4 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(6009001)(39860400002)(39840400002)(39450400003)(39850400002)(39410400002)(305945005)(99286003)(5660300001)(2900100001)(54906002)(9686003)(7736002)(2501003)(4326008)(229853002)(5005710100001)(10290500002)(8676002)(345774005)(25786008)(122556002)(50986999)(6436002)(5640700003)(8936002)(76176999)(55016002)(1730700003)(53936002)(54356999)(2906002)(106116001)(81166006)(3660700001)(6506006)(189998001)(86362001)(110136004)(33656002)(6246003)(77096006)(10090500001)(38730400002)(3280700002)(86612001)(74316002)(2351001)(7696004)(6916009)(450100002)(2950100002)(102836003)(6116002); DIR:OUT; SFP:1102; SCL:1; SRVR:MWHPR03MB2670; H:MWHPR03MB2669.namprd03.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2017 06:48:07.9063 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2670 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 06:48:10 -0000 > From: Rodney W. Grimes [mailto:freebsd@pdx.rh.CN85.dnsmgr.net] > Sent: Wednesday, March 8, 2017 12:33 > > Author: dexuan > > Date: Wed Mar 8 02:50:29 2017 > > New Revision: 314891 > > Log: > > loader.efi: finally fix the off-by-one bug in efi_verify_staging_size= () > > > > r314828(loader.efi: fix an off-by-one bug in efi_verify_staging_size(= )) > > doesn't really fix the bug and this patch adds the missing part. > > > > It's a shame that I didn't make everything correct at the very beginn= ing... >=20 > My thoughts on that: >=20 > Try as hard as we can and you well come up short on making software > correct in the beginning as it is an iterative process. Be glad you > have found and fixed yet another small problem, and hope that in > doing so you have not introduced another. >=20 > I thank you for your persuit of this latent issue in loader.efi! > -- > Rod Grimes =20 The lesson I learned here is that: do test the code with real test cases, no matter how confident I'm in the patch, and no matter how small the change would look like. And another issue here is that actually I don't have a local physical FreeBSD machine yet. Trying to set up one. Thanks, -- Dexuan