Date: Thu, 4 Apr 2019 19:04:49 +0900 From: Koichiro Iwao <meta@FreeBSD.org> To: Hiroki Sato <hrs@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r497400 - in head/net: . tigervnc tigervnc-server tigervnc-viewer Message-ID: <20190404100449.sli2ta4vkrxhvmpb@icepick.vmeta.jp> In-Reply-To: <20190404.172215.1570903530092886558.hrs@allbsd.org> References: <201903311310.x2VDA4cN047931@repo.freebsd.org> <20190404.172215.1570903530092886558.hrs@allbsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Apr 04, 2019 at 05:22:15PM +0900, Hiroki Sato wrote: > > If net/tigervnc now has only SERVER as the default options, it is no > longer worth keeping it as a meta-port because the resultant package > is an empty one which has a single dependency on tigervnc-server. An > entry to MOVED is sufficient in this case. > > Even if you want to keep this, at least you might want to take care > of backward compatibility with the old tigervnc. Both of SERVER and > VIEWER should be added back to it since it had VIEWER in > OPTIONS_DEFAULT. Thank you for the advice. I'll consider that. > LICENSE.TXT should not be installed into DOCSDIR. It will be > installed by specifying LICENSE_FILE in a per-package directory, so > you can simply drop it from DOCS. I understand now. The conflicting LICENSE.TXT in DOCSDIR is installed not by ports framework but upstream cmake. I was wondering why it conflicts that should not conflict. https://github.com/TigerVNC/tigervnc/blob/6011f96cdc5b8f68a864d7f6294d9a45030b3533/cmake/BuildPackages.cmake#L89 OTOH, LICENSE file installed by ports framework is located here, right? /usr/local/share/licenses/tigervnc-server-1.9.0_1/LICENSE Indeed LICENSE.TXT installed by upstream cmake can simply be dropped. -- meta <meta@FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190404100449.sli2ta4vkrxhvmpb>