Date: Mon, 21 May 2007 21:07:28 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Doug Barton <dougb@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, "Ralf S. Engelschall" <rse@FreeBSD.org>, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/rc.d hostid Message-ID: <86veemgfm7.fsf@dwp.des.no> In-Reply-To: <4651E90D.8030001@FreeBSD.org> (Doug Barton's message of "Mon\, 21 May 2007 11\:46\:37 -0700") References: <200705211144.l4LBiEHY098477@repoman.freebsd.org> <4651E084.1020605@FreeBSD.org> <86zm3yghuf.fsf@dwp.des.no> <4651E90D.8030001@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Doug Barton <dougb@FreeBSD.org> writes: > Dag-Erling Sm=C3=B8rgrav <des@des.no> writes: > > Doug Barton <dougb@FreeBSD.org> writes: > > > Meanwhile, I've attached a patch that simplifies the hostid_hardware() > > > quite a bit, and has the added virtue of only calling csh if it's > > > needed. > > It also fails to ensure that the UUID has the correct syntax. > If we're really concerned that this could be a problem (and I don't > know enough about it to comment) then feel free to wrap a syntax test > around the last echo. What I'm trying to do is simplify the routine, > and allow obviously bogus responses to be rejected with cheap tests. > > Given that this thing is on by default, and that people are always > complaining that rc.d stuff runs too slow, we need to be a little more > careful to do it well, rather than just good enough. The current code correctly checks for a syntactically correct UUID. Your proposed replacement does not. I fail to see how that qualifies as "doing well rather than just good enough" DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86veemgfm7.fsf>