Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 31 May 2002 14:11:41 -0700 (PDT)
From:      Archie Cobbs <archie@dellroad.org>
To:        Julian Elischer <julian@elischer.org>
Cc:        Archie Cobbs <archie@dellroad.org>, Bosko Milekic <bmilekic@unixdaemons.com>, freebsd-net@FreeBSD.ORG
Subject:   Re: m_split() considered harmful
Message-ID:  <200205312111.g4VLBff02718@arch20m.dellroad.org>
In-Reply-To: <Pine.BSF.4.21.0205311349260.29361-100000@InterJet.elischer.org> "from Julian Elischer at May 31, 2002 01:52:18 pm"

next in thread | previous in thread | raw e-mail | index | archive | help
Julian Elischer writes:
> > It's not clear whether the caller of M_TRAILINGSPACE()/M_LEADINGSPACE()
> > is responsible for checking for writability, or the macros themselves.
> > It seems to make more sense that the caller would be responsible...
> > why would you call M_TRAILINGSPACE() unless you wanted to write
> > something in there?
>
> M_TRAILINGSPACE is called to ask 
> "How much writable room is there after hte data here?

That's the other interpretation :-)

> your patch looks better now
> I'm wouldering however if any code other than that looks at ext_size

Like I said, I did an exhaustive search. The most interesting
example is sbdrop().

You can see for yourself.. there aren't that many files:

    vi `(cd /sys && find . -type f -print | xargs grep -lw ext_size)`

-Archie

__________________________________________________________________________
Archie Cobbs     *     Packet Design     *     http://www.packetdesign.com

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200205312111.g4VLBff02718>