Date: Tue, 5 Oct 2010 18:30:05 GMT From: Andriy Gapon <avg@icyb.net.ua> To: freebsd-acpi@FreeBSD.org Subject: Re: kern/150517: [acpi] acpi_ec does not work properly on Lenovo S10[e] (due to dynamic switching to polled mode) Message-ID: <201010051830.o95IU5vN063885@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/150517; it has been noted by GNATS. From: Andriy Gapon <avg@icyb.net.ua> To: David Naylor <naylor.b.david@gmail.com> Cc: bug-followup@freebsd.org Subject: Re: kern/150517: [acpi] acpi_ec does not work properly on Lenovo S10[e] (due to dynamic switching to polled mode) Date: Tue, 05 Oct 2010 21:28:18 +0300 on 05/10/2010 20:54 David Naylor said the following: > On Tuesday 05 October 2010 11:09:02 Andriy Gapon wrote: >> Can you try the patch? >> http://people.freebsd.org/~avg/acpi_ec.patch >> Thanks a lot! > > Two notes about your patch: > - EcCheckStatus has changed position in the file resulting in a larger than > required change. Yes, it's now needed in a function that is defined earlier. I could just have added a declaration for EcCheckStatus(), but for some reason I decided to move its definition. > - You no longer dynamically switch to polled mode. Was that intentional? Yes. My opinion is that it should be up to user to forcefully switch to polled mode. Although perhaps this is an unwelcome change for some users. Need to weight pros and cons. > Your patchs works. No errors were reported during the stress test, however > running acpiconf takes a noticeably longer time to complete (before and with > my patch it was instantaneous). Setting debug.acpi.ec.timeout=25 improves > responsiveness (reducing to 5 resulting in GPE query failed messages). > > Accoring to time acpiconf takes upto 3 seconds to complete, after setting > debug.acpi.ec.timeout it takes upto 0.24 seconds. > > I changed EC_POLL_DELAY back to 5 and that didn't change anything. I will investigate this. Thank you! -- Andriy Gapon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201010051830.o95IU5vN063885>