From owner-freebsd-acpi@FreeBSD.ORG  Tue Oct  5 18:30:06 2010
Return-Path: <owner-freebsd-acpi@FreeBSD.ORG>
Delivered-To: freebsd-acpi@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3D2101065674
	for <freebsd-acpi@hub.freebsd.org>;
	Tue,  5 Oct 2010 18:30:06 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 11DB78FC0C
	for <freebsd-acpi@hub.freebsd.org>;
	Tue,  5 Oct 2010 18:30:06 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o95IU52l063888
	for <freebsd-acpi@freefall.freebsd.org>; Tue, 5 Oct 2010 18:30:05 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o95IU5vN063885;
	Tue, 5 Oct 2010 18:30:05 GMT (envelope-from gnats)
Date: Tue, 5 Oct 2010 18:30:05 GMT
Message-Id: <201010051830.o95IU5vN063885@freefall.freebsd.org>
To: freebsd-acpi@FreeBSD.org
From: Andriy Gapon <avg@icyb.net.ua>
Cc: 
Subject: Re: kern/150517: [acpi] acpi_ec does not work properly on Lenovo
 S10[e] (due to dynamic switching to polled mode)
X-BeenThere: freebsd-acpi@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Andriy Gapon <avg@icyb.net.ua>
List-Id: ACPI and power management development <freebsd-acpi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-acpi>
List-Post: <mailto:freebsd-acpi@freebsd.org>
List-Help: <mailto:freebsd-acpi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
	<mailto:freebsd-acpi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Oct 2010 18:30:06 -0000

The following reply was made to PR kern/150517; it has been noted by GNATS.

From: Andriy Gapon <avg@icyb.net.ua>
To: David Naylor <naylor.b.david@gmail.com>
Cc: bug-followup@freebsd.org
Subject: Re: kern/150517: [acpi] acpi_ec does not work properly on Lenovo
 S10[e] (due to dynamic switching to polled mode)
Date: Tue, 05 Oct 2010 21:28:18 +0300

 on 05/10/2010 20:54 David Naylor said the following:
 > On Tuesday 05 October 2010 11:09:02 Andriy Gapon wrote:
 >> Can you try the patch?
 >> http://people.freebsd.org/~avg/acpi_ec.patch
 >> Thanks a lot!
 > 
 > Two notes about your patch:
 >  - EcCheckStatus has changed position in the file resulting in a larger than 
 > required change.
 
 Yes, it's now needed in a function that is defined earlier.
 I could just have added a declaration for EcCheckStatus(), but for some reason I
 decided to move its definition.
 
 >  - You no longer dynamically switch to polled mode.  Was that intentional?
 
 Yes.  My opinion is that it should be up to user to forcefully switch to polled
 mode.  Although perhaps this is an unwelcome change for some users.  Need to
 weight pros and cons.
 
 > Your patchs works.  No errors were reported during the stress test, however 
 > running acpiconf takes a noticeably longer time to complete (before and with 
 > my patch it was instantaneous).  Setting debug.acpi.ec.timeout=25 improves 
 > responsiveness (reducing to 5 resulting in GPE query failed messages).  
 > 
 > Accoring to time acpiconf takes upto 3 seconds to complete, after setting 
 > debug.acpi.ec.timeout it takes upto 0.24 seconds.  
 > 
 > I changed EC_POLL_DELAY back to 5 and that didn't change anything.  
 
 I will investigate this.
 Thank you!
 
 -- 
 Andriy Gapon