From owner-freebsd-ports@FreeBSD.ORG Tue Sep 8 21:10:29 2009 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 85AB51065693 for ; Tue, 8 Sep 2009 21:10:29 +0000 (UTC) (envelope-from wxs@atarininja.org) Received: from syn.atarininja.org (syn.csh.rit.edu [129.21.60.158]) by mx1.freebsd.org (Postfix) with ESMTP id 42DDC8FC32 for ; Tue, 8 Sep 2009 21:10:28 +0000 (UTC) Received: by syn.atarininja.org (Postfix, from userid 1001) id 46EFA5C3B; Tue, 8 Sep 2009 17:10:28 -0400 (EDT) Date: Tue, 8 Sep 2009 17:10:28 -0400 From: Wesley Shields To: Dag-Erling Sm??rgrav Message-ID: <20090908211028.GA95404@atarininja.org> References: <864ordn5kz.fsf@ds4.des.no> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <864ordn5kz.fsf@ds4.des.no> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: ports@freebsd.org Subject: Re: {incorrect,unsafe} use of UNZIP_CMD X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Sep 2009 21:10:29 -0000 On Tue, Sep 08, 2009 at 11:33:48AM +0200, Dag-Erling Sm??rgrav wrote: > des@tim /usr/ports% find . -mindepth 3 -type f -name Makefile | xargs grep 'DEPEND.*UNZIP' /dev/null > ./audio/libamrnb/Makefile:BUILD_DEPENDS= ${UNZIP_CMD}:${PORTSDIR}/archivers/unzip > ./audio/libamrwb/Makefile:BUILD_DEPENDS= ${UNZIP_CMD}:${PORTSDIR}/archivers/unzip > ./databases/pgtcl/Makefile:BUILD_DEPENDS= ${UNZIP_CMD}:${PORTSDIR}/archivers/unzip > ./emulators/xgs/Makefile:EXTRACT_DEPENDS= ${UNZIP_CMD}:${PORTSDIR}/archivers/unzip > ./games/pykawari/Makefile:EXTRACT_DEPENDS=${UNZIP_CMD}:${PORTSDIR}/archivers/unzip > ./lang/f2c/Makefile:EXTRACT_DEPENDS=${UNZIP_CMD}:${PORTSDIR}/archivers/unzip > > This will fail if the user redefines UNZIP_CMD to e.g. "unzip -v". I just fixed these. Thanks for noticing. The rest of these are not fatal errors but should eventually be cleaned up. If nobody gets to this before me I will get to it in a week or two, or after the freeze if necessary. -- WXS > all of these should just set USE_ZIP: > > des@tim /usr/ports% find . -mindepth 3 -type f -name Makefile | xargs egrep 'EXTRACT_DEPENDS.*(UNZIP|unzip)' /dev/null > ./cad/leocad/Makefile:EXTRACT_DEPENDS=unzip:${PORTSDIR}/archivers/unzip > ./deskutils/superkaramba-lwp/Makefile:EXTRACT_DEPENDS= unzip:${PORTSDIR}/archivers/unzip > ./devel/tavrasm/Makefile:EXTRACT_DEPENDS=unzip:${PORTSDIR}/archivers/unzip > ./emulators/xgs/Makefile:EXTRACT_DEPENDS= ${UNZIP_CMD}:${PORTSDIR}/archivers/unzip > ./emulators/m2000/Makefile:EXTRACT_DEPENDS=unzip:${PORTSDIR}/archivers/unzip > ./emulators/vmsbackup/Makefile:EXTRACT_DEPENDS=unzip:${PORTSDIR}/archivers/unzip > ./games/cgoban2/Makefile:EXTRACT_DEPENDS=unzip:${PORTSDIR}/archivers/unzip > ./games/openarena/Makefile:EXTRACT_DEPENDS=unzip:${PORTSDIR}/archivers/unzip > ./games/pykawari/Makefile:EXTRACT_DEPENDS=${UNZIP_CMD}:${PORTSDIR}/archivers/unzip > ./games/sdb/Makefile:EXTRACT_DEPENDS+= unzip:${PORTSDIR}/archivers/unzip > ./games/ezquake/Makefile:EXTRACT_DEPENDS=unzip:${PORTSDIR}/archivers/unzip \ > ./games/ufoai-data/Makefile:EXTRACT_DEPENDS=unzip:${PORTSDIR}/archivers/unzip > ./games/quake-data/Makefile:EXTRACT_DEPENDS+= unzip:${PORTSDIR}/archivers/unzip > ./games/quake-extras/Makefile:EXTRACT_DEPENDS+= unzip:${PORTSDIR}/archivers/unzip > ./games/tremor/Makefile:EXTRACT_DEPENDS=unzip:${PORTSDIR}/archivers/unzip > ./games/doomlegacy/Makefile:EXTRACT_DEPENDS=unzip:${PORTSDIR}/archivers/unzip > ./games/uhexen/Makefile:EXTRACT_DEPENDS= unzip:${PORTSDIR}/archivers/unzip > ./games/kmquake2/Makefile:EXTRACT_DEPENDS=unzip:${PORTSDIR}/archivers/unzip > ./games/galaxyhack/Makefile:EXTRACT_DEPENDS+= unzip:${PORTSDIR}/archivers/unzip > ./hungarian/hunspell/Makefile:#EXTRACT_DEPENDS= unzip:${PORTSDIR}/archivers/unzip > ./japanese/edict-utf-8/Makefile:EXTRACT_DEPENDS= unzip:${PORTSDIR}/archivers/unzip > ./japanese/tomoe/Makefile:EXTRACT_DEPENDS+= unzip:${PORTSDIR}/archivers/unzip > ./java/diablo-jdk15/Makefile:EXTRACT_DEPENDS+= unzip:${PORTSDIR}/archivers/unzip > ./java/diablo-jdk16/Makefile:EXTRACT_DEPENDS+= unzip:${PORTSDIR}/archivers/unzip > ./java/diablo-jre15/Makefile:EXTRACT_DEPENDS+= unzip:${PORTSDIR}/archivers/unzip > ./java/diablo-jre16/Makefile:EXTRACT_DEPENDS+= unzip:${PORTSDIR}/archivers/unzip > ./java/sun-wtk/Makefile:EXTRACT_DEPENDS+= unzip:${PORTSDIR}/archivers/unzip > ./lang/f2c/Makefile:EXTRACT_DEPENDS=${UNZIP_CMD}:${PORTSDIR}/archivers/unzip > ./sysutils/memtest86/Makefile:EXTRACT_DEPENDS= unzip:${PORTSDIR}/archivers/unzip > ./textproc/fop/Makefile:EXTRACT_DEPENDS+= unzip:${PORTSDIR}/archivers/unzip > ./www/mambo/Makefile:EXTRACT_DEPENDS= unzip:${PORTSDIR}/archivers/unzip > > So should these: > > des@tim /usr/ports% find . -mindepth 3 -type f -name Makefile | xargs egrep 'EXTRACT_CMD.*(UNZIP|unzip)' /dev/null > ./deskutils/superkaramba-lwp/Makefile:EXTRACT_CMD= ${UNZIP_CMD} > ./games/pykawari/Makefile:EXTRACT_CMD= ${UNZIP_CMD} > ./misc/projectionlib/Makefile:EXTRACT_CMD= unzip -a > > java/jdk14 is just... weird. I won't paste the Makefile here. > > DES > -- > Dag-Erling Sm??rgrav - des@des.no > _______________________________________________ > freebsd-ports@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-ports > To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org"