Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 29 Dec 2017 16:16:00 +0000 (UTC)
From:      Ed Maste <emaste@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r457511 - head/multimedia/xine
Message-ID:  <201712291616.vBTGG0OG098629@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: emaste (src committer)
Date: Fri Dec 29 16:16:00 2017
New Revision: 457511
URL: https://svnweb.freebsd.org/changeset/ports/457511

Log:
  multimedia/xine: set LLD_UNSAFE to avoid lld
  
  xine relies on ld.bfd's permissive treatment of shared library symbols
  with protected visibility, and attempting to link with lld fails with
  errors like:
  
  /usr/bin/ld: error: cannot preempt symbol: xine_usec_sleep
  >>> defined in /usr/local/lib/libxine.so
  >>> referenced by actions.c
  >>>               actions.o:(wait_for_window_visible)
  
  For now set LLD_UNSAFE=yes so that the port will continue to link with
  ld.bfd if /usr/bin/ld is lld, until the issue can be addressed (with a
  change in libxine or in lld).
  
  PR:		214864
  Approved by:	portmgr (LLD_UNSAFE blanket)
  Sponsored by:	The FreeBSD Foundation

Modified:
  head/multimedia/xine/Makefile

Modified: head/multimedia/xine/Makefile
==============================================================================
--- head/multimedia/xine/Makefile	Fri Dec 29 15:47:00 2017	(r457510)
+++ head/multimedia/xine/Makefile	Fri Dec 29 16:16:00 2017	(r457511)
@@ -27,6 +27,7 @@ INSTALLS_ICONS=	yes
 
 CPPFLAGS+=	-I${LOCALBASE}/include
 LDFLAGS+=	-L${LOCALBASE}/lib
+LLD_UNSAFE=	yes	# lld disallows preemption of protected visibility syms
 
 DOCSDIR=	${PREFIX}/share/doc/xine-ui
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201712291616.vBTGG0OG098629>