Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 23 Feb 2017 16:18:57 +0000 (UTC)
From:      "Pedro F. Giffuni" <pfg@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r314147 - head/sys/dev/bktr
Message-ID:  <201702231618.v1NGIv56045000@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: pfg
Date: Thu Feb 23 16:18:57 2017
New Revision: 314147
URL: https://svnweb.freebsd.org/changeset/base/314147

Log:
  bktr(4): double assignment.
  
  First assignment is obviously overwritten by the next line.
  Leave newest assignment: it was introduced in r29233.
  
  Found with:	coccinelle (da.cocci)

Modified:
  head/sys/dev/bktr/bktr_core.c

Modified: head/sys/dev/bktr/bktr_core.c
==============================================================================
--- head/sys/dev/bktr/bktr_core.c	Thu Feb 23 16:15:42 2017	(r314146)
+++ head/sys/dev/bktr/bktr_core.c	Thu Feb 23 16:18:57 2017	(r314147)
@@ -3121,7 +3121,6 @@ yuvpack_prog( bktr_ptr_t bktr, char i_fl
 	OUTB(bktr, BKTR_COLOR_CTL, INB(bktr, BKTR_COLOR_CTL) | BT848_COLOR_CTL_RGB_DED | BT848_COLOR_CTL_GAMMA);
 	OUTB(bktr, BKTR_ADC, SYNC_LEVEL);
 
-	bktr->capcontrol =   1 << 6 | 1 << 4 | 1 << 2 | 3;
 	bktr->capcontrol = 3 << 2 |  3;
 
 	dma_prog = (uint32_t *) bktr->dma_prog;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201702231618.v1NGIv56045000>