Date: Sat, 26 Aug 2017 10:27:21 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: "Danilo G. Baio" <dbaio@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r448747 - in head/mail: . smfsav smfsav-devel smfsav-devel/files Message-ID: <b954dca4-829b-edd9-57b3-7285ebd96306@FreeBSD.org> In-Reply-To: <201708260118.v7Q1IGxA078692@repo.freebsd.org> References: <201708260118.v7Q1IGxA078692@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--OL1OfwbPBKPwQ0ms0raq23SCP8w7VWnN5
Content-Type: multipart/mixed; boundary="kf8jC4XusHu6uVSPHtWJdm0crBIo97sQB";
protected-headers="v1"
From: Mathieu Arnold <mat@FreeBSD.org>
To: "Danilo G. Baio" <dbaio@FreeBSD.org>, ports-committers@freebsd.org,
svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Message-ID: <b954dca4-829b-edd9-57b3-7285ebd96306@FreeBSD.org>
Subject: Re: svn commit: r448747 - in head/mail: . smfsav smfsav-devel
smfsav-devel/files
References: <201708260118.v7Q1IGxA078692@repo.freebsd.org>
In-Reply-To: <201708260118.v7Q1IGxA078692@repo.freebsd.org>
--kf8jC4XusHu6uVSPHtWJdm0crBIo97sQB
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: fr
Le 26/08/2017 =C3=A0 03:18, Danilo G. Baio a =C3=A9crit=C2=A0:
> PLIST_SUB=3D SMFSAV_RUN_DIR=3D${SMFSAV_RUN_DIR}
> SUB_FILES+=3D pkg-message
> +SUB_LIST=3D ${PLIST_SUB}
This is a very bad idea, it does not do what you think it does.
$ make -V SUB_LIST
SMFSAV_RUN_DIR=3D/var/run/smfs OSREL=3D11.1 PREFIX=3D%D LOCALBASE=3D/usr/=
local=C2=A0
RESETPREFIX=3D/usr/local PORTDOCS=3D"" PORTEXAMPLES=3D"" LIB32DIR=3Dlib
DOCSDIR=3D"share/doc/smfsav"=C2=A0 EXAMPLESDIR=3D"share/examples/smfsav"=C2=
=A0
DATADIR=3D"share/smfsav"=C2=A0 WWWDIR=3D"www/smfsav"=C2=A0 ETCDIR=3D"etc/=
smfsav"
PREFIX=3D/usr/local LOCALBASE=3D/usr/local=C2=A0 DATADIR=3D/usr/local/sha=
re/smfsav
DOCSDIR=3D/usr/local/share/doc/smfsav
EXAMPLESDIR=3D/usr/local/share/examples/smfsav=C2=A0
WWWDIR=3D/usr/local/www/smfsav ETCDIR=3D/usr/local/etc/smfsav
Now, you have two instances of many variables in there, for example:
$ make -V SUB_LIST:METCDIR*
ETCDIR=3D"etc/smfsav" ETCDIR=3D/usr/local/etc/smfsav
It is completely unsupported, and I am quite sure it would likely break
very badly.
A quick fix would be to change =3D by :=3D, but :=3D sometime does other
things that you do not expect. It would probably be better to dupplicate
the content.
--=20
Mathieu Arnold
--kf8jC4XusHu6uVSPHtWJdm0crBIo97sQB--
--OL1OfwbPBKPwQ0ms0raq23SCP8w7VWnN5
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQJ8BAEBCgBmBQJZoTDsXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85I394QAKSeoifPhKa3vl5kN8X/dlC3
relRCruaKnQMaUk1NeI2ofMwBEjF9f0H28h82HSR7B2uHevLRtuK6vLcFDjIPmkf
7uHSpj4vi54s6BQlD8lym5k84/in1SaR+E+udNAHMD+m5SSjcudSMJULf3YFQiqu
xC5ax4ahQJIo8azv+YBPqIQIj8hn3x5HuqdiMdfbX2IHCg9MN9UsyDKqGgeODL0I
ZtC8mgr/NJbNrGKbIA00fedAIkwnx4QfK5DJFA/ZS6ZWwiDFMSihnr8t+a0s7x3+
7B/mdcs1AJU7hnWjR+94S5YBb7P827HsTJh2jL6x0vBzoX/QKZ1JBC6DGBTo27Bj
RJwkIS6jGCQZnXqfeOcUxeQ5M2dhTy/ApKHEZiJc8DqlzLSKSA4vz0uBYJXockuG
p1Tz017x+LvIhzdzyI0XEtqo+bfdGwGnGb+dacsQjRMl6YKPU7BEJCNJEqxXlm3+
WydH9UoSkubowbwuRqHpzyRsDFsqQLg1djosshx1bZz0lN4w+jE4AD3GUQlkaq/t
jqTEezT5u+/CSr+iMuD5xU8u+DRrbTtT4hT1KidoA1qKLEJC7TIPqSYFzWNsG6iy
BQelEF2JdmSNIPIbhwV/2VCj3kofOK2x4rSHqjapzWKiCQIVcrWvyx8EF2uXOpk4
7+z8Zvm62EIM4au8hMS/
=MUB1
-----END PGP SIGNATURE-----
--OL1OfwbPBKPwQ0ms0raq23SCP8w7VWnN5--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b954dca4-829b-edd9-57b3-7285ebd96306>