From owner-svn-ports-head@freebsd.org Fri Jul 13 06:43:40 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3FB88102B57B; Fri, 13 Jul 2018 06:43:40 +0000 (UTC) (envelope-from tobik@FreeBSD.org) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D34B377679; Fri, 13 Jul 2018 06:43:39 +0000 (UTC) (envelope-from tobik@FreeBSD.org) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 46390313; Fri, 13 Jul 2018 02:43:37 -0400 (EDT) Received: from web2 ([10.202.2.212]) by compute4.internal (MEProxy); Fri, 13 Jul 2018 02:43:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=2Jl0vX eGHcEVDrqxlAs+0ny47PbJsmhfs1D+24XF9Zw=; b=fUJOf2n0HWxfoDedy0VPsM gO8r0Wu3X8NsIhM870EQK5MSLrx8b0LzSK3zB3GTP9xSfptfaCPcKV8/xwnal3QQ eWTtGf0Uue4LeooopVidxTkDAxpOOs7YQsrgaYb/QyBOfOrIyhlsAst+foVN+9Co opXGqbk9ptVXQQc8WyzC2M4tjU3RFA0mDGHND04J3nNxGDgepRVrZrIvPsXrBy4+ f8IEsxIFCekC0UKeiCFk/u+yevOZatTqbgZYeFVnd4sZmSZuKz0ZUSuBvYxEWDMB jraWxqOczl5pjKhUyoFU/enhCoJX9sqH2pOCTZvCB8fGXYw4A73VeOzJ97/uOC1A == X-ME-Proxy: X-ME-Sender: Received: by mailuser.nyi.internal (Postfix, from userid 99) id A1ADF621DC; Fri, 13 Jul 2018 02:43:36 -0400 (EDT) Message-Id: <1531464216.1955680.1439350032.7AC058F0@webmail.messagingengine.com> From: Tobias Kortkamp To: Dmitry Marakasov , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-957169fa References: <201807121411.w6CEBlZn074328@repo.freebsd.org> In-Reply-To: <201807121411.w6CEBlZn074328@repo.freebsd.org> Subject: Re: svn commit: r474520 - head/x11-clocks/glclock Date: Fri, 13 Jul 2018 08:43:36 +0200 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jul 2018 06:43:40 -0000 On Thu, Jul 12, 2018, at 16:11, Dmitry Marakasov wrote: > Author: amdmi3 > Date: Thu Jul 12 14:11:46 2018 > New Revision: 474520 > URL: https://svnweb.freebsd.org/changeset/ports/474520 > > Log: > - Fix build with clang 6 > > Modified: > head/x11-clocks/glclock/Makefile > > Modified: head/x11-clocks/glclock/Makefile > ============================================================================== > --- head/x11-clocks/glclock/Makefile Thu Jul 12 14:11:30 2018 (r474519) > +++ head/x11-clocks/glclock/Makefile Thu Jul 12 14:11:46 2018 (r474520) > @@ -15,6 +15,7 @@ USE_GL= gl glu glut > MAKEFILE= makefile > > CFLAGS+= -DIMAGE_PATH="\\\"${PREFIX}/lib/X11/glclock/\\\"" > +CXXFLAGS+= -Wno-c++11-narrowing Why is this needed after r474251? Was the previous fix not enough? Can you include a copy of the errors this fixes in the commit message and/or maybe add a link to the build failure log? Besides that this breaks the build on Tier 2 archs like powerpc. gcc 4.2 doesn't recognize -Wno-c++11-narrowing and treats it as an error: cc1plus: error: unrecognized command line option "-Wno-c++11-narrowing" I think something like USES= compiler CXXFLAGS+= ${CXXFLAGS_${CHOSEN_COMPILER_TYPE}} CXXFLAGS_clang= -Wno-c++11-narrowing or similar would be better. > > PLIST_FILES= ${PROGRAMS:S,^,bin/,} ${SCRIPTS:S,^,bin/,} \ > ${TEXTURES:S,^,lib/X11/glclock/,} >