Date: 03 Feb 2002 01:56:33 +0200 From: Maxim Sobolev <sobomax@mail.ru> To: Joe Clarke <marcus@marcuscom.com> Cc: gnome@FreeBSD.ORG Subject: Re: Missing continue in patch-ltmain.sh Message-ID: <1012694178.927.33.camel@notebook> In-Reply-To: <1012689198.65931.43.camel@shumai.marcuscom.com> References: <1012689198.65931.43.camel@shumai.marcuscom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-AzS3U5IkQC9mp7y+bCcl
Content-Type: multipart/mixed; boundary="=-4aVDPLoj3lw4KDuoyHHY"
--=-4aVDPLoj3lw4KDuoyHHY
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
On Sun, 2002-02-03 at 00:33, Joe Clarke wrote:
> Maxim, the recent changes you made to patch-ltmain.sh in a few ports
> have had a bad effect on -stable. These ports will refuse to link due
> to -pthread missing from the linker arguments. The problem is the
> continue you added after compiler_flags=3D"$compiler_flags -pthread",
> compiler_flags gets overwritten. I think the continue should be left
> out when setting compiler_flags.
>=20
> The problem affects glade and mrproject at least. It looks like any
> port that contains an application will run into this problem in the
> linking phase. Therefore, gnomevfs is not affected.
Grrr, it seems that libtool doesn't use compiler_flags when linking
executable. Attached please find updated version of patch-ltmain.sh
which should fix the issue. Unfortunately currently I do not have a 4.x
machine to test this patch on, so that it would be really nice if you
could test it with failing ports (mrproject and glade) and let me know
ASAP.
Thanks!
-Maxim
P.S. As the patch-ltmain.sh growth larger and larger I'm more and more
tempted to take several days and rewrite libtool in C specifically for
FreeBSD.
--=-4aVDPLoj3lw4KDuoyHHY
Content-Disposition: attachment; filename=patch-ltmain.sh
Content-Type: text/x-sh; charset=KOI8-R
Content-Transfer-Encoding: quoted-printable
$FreeBSD$
--- ltmain.sh.orig Wed Jan 23 11:38:40 2002
+++ ltmain.sh Sun Feb 3 01:44:17 2002
@@ -1037,8 +1037,16 @@
continue
;;
=20
+ -pthread)
+ compile_command=3D"$compile_command -pthread"
+ finalize_command=3D"$finalize_command -pthread"
+ compiler_flags=3D"$compiler_flags -pthread"
+ continue
+ ;;
+
-module)
module=3Dyes
+ build_old_libs=3Dno
continue
;;
=20
@@ -2412,6 +2420,9 @@
*-*-netbsd*)
# Don't link with libc until the a.out ld.so is fixed.
;;
+ *-*-freebsd*)
+ # FreeBSD doesn't need this...
+ ;;
*)
# Add libc to deplibs on all other systems if necessary.
if test "$build_libtool_need_lc" =3D "yes"; then
@@ -4179,10 +4190,12 @@
fi
=20
# Install the pseudo-library for information purposes.
+ if /usr/bin/false; then
name=3D`$echo "X$file" | $Xsed -e 's%^.*/%%'`
instname=3D"$dir/$name"i
$show "$install_prog $instname $destdir/$name"
$run eval "$install_prog $instname $destdir/$name" || exit $?
+ fi
=20
# Maybe install the static library, too.
test -n "$old_library" && staticlibs=3D"$staticlibs $dir/$old_library"
--=-4aVDPLoj3lw4KDuoyHHY--
--=-AzS3U5IkQC9mp7y+bCcl
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (FreeBSD)
Comment: For info see http://www.gnupg.org
iD8DBQA8XHyfoNu5t4iCBa8RAtMyAJ9GQ/RNhqONDeI3MgjTjYU8lvQymACcCtD3
vOS832G/06sez/UyiIslGVY=
=TL9I
-----END PGP SIGNATURE-----
--=-AzS3U5IkQC9mp7y+bCcl--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-gnome" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1012694178.927.33.camel>