Date: Sun, 06 Jul 2008 11:09:43 +0900 (JST) From: Takahashi Yoshihiro <nyan@jp.FreeBSD.org> To: marcel@freebsd.org Cc: perforce@freebsd.org Subject: Re: PERFORCE change 144741 for review Message-ID: <20080706.110943.226722229.nyan@jp.FreeBSD.org> In-Reply-To: <200807051943.m65JhHZ6066371@repoman.freebsd.org> References: <200807051943.m65JhHZ6066371@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In article <200807051943.m65JhHZ6066371@repoman.freebsd.org>
Marcel Moolenaar <marcel@freebsd.org> writes:
> static struct isa_pnp_id isa_i8251_ids[] = {
> {0x0100e4a5, "RSA-98III"},
> {0}
> };
> /* Probe PnP _and_ non-PnP i8251 here. */
> if (ISA_PNP_PROBE(parent, dev, isa_i8251_ids) != ENXIO) {
> sc->sc_class = &uart_i8251_class;
> return (uart_bus_probe(dev, 0, 0, 0, 0));
> }
These are wrong. RSA98-III is based on ns8250 and has extended FIFO
buffer. So I think that the uart_rsa_class should be added.
FYI, RSA series are not for pc98 only.
RSA-PCI (PCI) and RSA-DVII (ISA) exist but not supported yet.
---
TAKAHASHI Yoshihiro <nyan@jp.FreeBSD.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080706.110943.226722229.nyan>