Date: Sat, 14 Nov 2015 00:42:04 +0300 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Steven Hartland <smh@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r290403 - head/sys/netinet Message-ID: <20151113214204.GA73031@FreeBSD.org> In-Reply-To: <201511051723.tA5HN24j065530@repo.freebsd.org> References: <201511051723.tA5HN24j065530@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Steven, On Thu, Nov 05, 2015 at 05:23:02PM +0000, Steven Hartland wrote: S> Author: smh S> Date: Thu Nov 5 17:23:02 2015 S> New Revision: 290403 S> URL: https://svnweb.freebsd.org/changeset/base/290403 S> S> Log: S> Add MTU support to carp interfaces S> S> MFC after: 2 weeks S> Sponsored by: Multiplay What is "carp interfaces"? I believe you are committing a patch to FreeBSD 9 into FreeBSD 11, w/o doing any testing and w/o doing even light review of surrounding code, which differes a lot from FreeBSD 9. Please back this out or correct me being wrong. S> Modified: S> head/sys/netinet/ip_carp.c S> S> Modified: head/sys/netinet/ip_carp.c S> ============================================================================== S> --- head/sys/netinet/ip_carp.c Thu Nov 5 17:19:08 2015 (r290402) S> +++ head/sys/netinet/ip_carp.c Thu Nov 5 17:23:02 2015 (r290403) S> @@ -1769,6 +1769,13 @@ carp_ioctl(struct ifreq *ifr, u_long cmd S> } S> break; S> } S> + case SIOCSIFMTU: S> + if (ifr->ifr_mtu > ETHERMTU_JUMBO) { S> + error = EINVAL; S> + } else { S> + ifp->if_mtu = ifr->ifr_mtu; S> + } S> + break; S> default: S> error = EINVAL; S> } S> _______________________________________________ S> svn-src-all@freebsd.org mailing list S> https://lists.freebsd.org/mailman/listinfo/svn-src-all S> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" -- Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151113214204.GA73031>