From owner-cvs-all@FreeBSD.ORG Fri Mar 12 14:23:00 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DB3F816A4CE; Fri, 12 Mar 2004 14:23:00 -0800 (PST) Received: from mtaw4.prodigy.net (mtaw4.prodigy.net [64.164.98.52]) by mx1.FreeBSD.org (Postfix) with ESMTP id B040543D31; Fri, 12 Mar 2004 14:23:00 -0800 (PST) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (dbee1c9074c04c14e87f68cbb67edbf2@adsl-67-119-53-203.dsl.lsan03.pacbell.net [67.119.53.203]) by mtaw4.prodigy.net (8.12.10/8.12.10) with ESMTP id i2CMMnox003307; Fri, 12 Mar 2004 14:22:56 -0800 (PST) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 6C875511C9; Fri, 12 Mar 2004 14:22:42 -0800 (PST) Date: Fri, 12 Mar 2004 14:22:42 -0800 From: Kris Kennaway To: Ruslan Ermilov Message-ID: <20040312222242.GA46557@xor.obsecurity.org> References: <200403122106.i2CL6Kb6090102@repoman.freebsd.org> <20040312215450.GB46054@xor.obsecurity.org> <20040312220439.GC4588@ip.net.ua> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Q68bSM7Ycu6FN28Q" Content-Disposition: inline In-Reply-To: <20040312220439.GC4588@ip.net.ua> User-Agent: Mutt/1.4.2.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Kris Kennaway Subject: Re: cvs commit: src/sys/kern kern_exec.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Mar 2004 22:23:01 -0000 --Q68bSM7Ycu6FN28Q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 13, 2004 at 12:04:39AM +0200, Ruslan Ermilov wrote: > On Fri, Mar 12, 2004 at 01:54:50PM -0800, Kris Kennaway wrote: > > On Fri, Mar 12, 2004 at 01:06:20PM -0800, Ruslan Ermilov wrote: > > > ru 2004/03/12 13:06:20 PST > > >=20 > > > FreeBSD src repository > > >=20 > > > Modified files: > > > sys/kern kern_exec.c=20 > > > Log: > > > Do what the execve(2) manpage says and enforce what a Strictly > > > Conforming POSIX application should do by disallowing the argv > > > argument to be NULL. > > > =20 > > > PR: kern/33738 > > > Submitted by: Marc Olzheim, Serge van den Boom > > > OK'ed by: nectar > >=20 > > Is this likely to break any third party software (e.g. ports)? If so, > > please bump __FreeBSD_version. > >=20 > It'll break only broken software, so I don't think the bump is in order. Well, that doesn't follow. When third party software suddenly stops running on FreeBSD, we need a way to predict in advance whether or not it will run on a given kernel -- whether the software is "broken" in an ideological sense or not. For example, we need to mark the port BROKEN on those versions of FreeBSD so the user doesn't waste their time worrying about or reporting a known problem. __FreeBSD_version bumps have negligible cost, so if we're both wrong and this has no effect, then no harm is done. Kris --Q68bSM7Ycu6FN28Q Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFAUjgyWry0BWjoQKURAnPaAJ9maSiPoPIAV1bgMpovqii1pRvxPQCeP+i+ sHX7iZ8LqK2rnFj8na2HnWY= =KL7V -----END PGP SIGNATURE----- --Q68bSM7Ycu6FN28Q--