Date: Sat, 29 Mar 1997 13:04:09 -0700 From: Steve Passe <smp@csn.net> To: Richard Tobin <richard@cogsci.ed.ac.uk> Cc: multimedia@freebsd.org Subject: Re: Tuner AFC Message-ID: <199703292004.NAA15034@Ilsa.StevesCafe.com> In-Reply-To: Your message of "Sat, 29 Mar 1997 19:55:45 GMT." <28029.199703291955@pitcairn.cogsci.ed.ac.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, > case TVTUNER_SAFC: > bktr->tuner.afc = TRUE; > *(int *)arg = 1; > break; > > case TVTUNER_CAFC: > bktr->tuner.afc = FALSE; > *(int *)arg = 0; > break; > > I don't see the point of returning 1 or 0 in arg since the > program knows what state it's set! If it returned the OLD value of > tuner.afc that would be far more useful. Or perhaps have SETAFC > and GETAFC which would allow a program to set an AFC button to the > right state when it starts. ie: > > case TVTUNER_SETAFC: > bktr->tuner.afc = *(int *)arg; > break; > > case TVTUNER_GETAFC: > *(int *)arg = bktr->tuner.afc; > break; again, not enough time, I just used them as placeholders for args... I like your last suggestion, ie TVTUNER_SETAFC & TVTUNER_GETAFC. People, play around with these variations and let me know what works best in real life. -- Steve Passe | powered by smp@csn.net | Symmetric MultiProcessor FreeBSD
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199703292004.NAA15034>