From owner-freebsd-multimedia Sat Mar 29 12:04:24 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id MAA10091 for multimedia-outgoing; Sat, 29 Mar 1997 12:04:24 -0800 (PST) Received: from Ilsa.StevesCafe.com (sc-gw.StevesCafe.com [205.168.119.191]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id MAA10076 for ; Sat, 29 Mar 1997 12:04:16 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by Ilsa.StevesCafe.com (8.7.5/8.6.12) with SMTP id NAA15034; Sat, 29 Mar 1997 13:04:09 -0700 (MST) Message-Id: <199703292004.NAA15034@Ilsa.StevesCafe.com> X-Authentication-Warning: Ilsa.StevesCafe.com: Host localhost [127.0.0.1] didn't use HELO protocol X-Mailer: exmh version 1.6.5 12/11/95 From: Steve Passe To: Richard Tobin cc: multimedia@freebsd.org Subject: Re: Tuner AFC In-reply-to: Your message of "Sat, 29 Mar 1997 19:55:45 GMT." <28029.199703291955@pitcairn.cogsci.ed.ac.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sat, 29 Mar 1997 13:04:09 -0700 Sender: owner-multimedia@freebsd.org X-Loop: FreeBSD.org Precedence: bulk Hi, > case TVTUNER_SAFC: > bktr->tuner.afc = TRUE; > *(int *)arg = 1; > break; > > case TVTUNER_CAFC: > bktr->tuner.afc = FALSE; > *(int *)arg = 0; > break; > > I don't see the point of returning 1 or 0 in arg since the > program knows what state it's set! If it returned the OLD value of > tuner.afc that would be far more useful. Or perhaps have SETAFC > and GETAFC which would allow a program to set an AFC button to the > right state when it starts. ie: > > case TVTUNER_SETAFC: > bktr->tuner.afc = *(int *)arg; > break; > > case TVTUNER_GETAFC: > *(int *)arg = bktr->tuner.afc; > break; again, not enough time, I just used them as placeholders for args... I like your last suggestion, ie TVTUNER_SETAFC & TVTUNER_GETAFC. People, play around with these variations and let me know what works best in real life. -- Steve Passe | powered by smp@csn.net | Symmetric MultiProcessor FreeBSD