Date: Wed, 14 Sep 2016 16:39:13 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Guido Falsi <madpilot@FreeBSD.org>, Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Cc: portmgr@FreeBSD.org Subject: Re: svn commit: r422151 - head/devel/php70-APCu Message-ID: <0f3a866e-505b-1cbf-32d1-b543949841ee@FreeBSD.org> In-Reply-To: <d6b37fbc-02f6-8cb0-63a6-42dc7b1ec989@FreeBSD.org> References: <201609141913.u8EJD7pP073092@repo.freebsd.org> <1ac065a3-8ddb-0e3b-4d21-d35d726fb63e@FreeBSD.org> <d6b37fbc-02f6-8cb0-63a6-42dc7b1ec989@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8Xd0w8ka7iLWtw2tjq5hLf62NGAGRLudG Content-Type: multipart/mixed; boundary="Onk434q0N4sITDfweVXgVJgsQwifpJoAI"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Guido Falsi <madpilot@FreeBSD.org>, Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Cc: portmgr@FreeBSD.org Message-ID: <0f3a866e-505b-1cbf-32d1-b543949841ee@FreeBSD.org> Subject: Re: svn commit: r422151 - head/devel/php70-APCu References: <201609141913.u8EJD7pP073092@repo.freebsd.org> <1ac065a3-8ddb-0e3b-4d21-d35d726fb63e@FreeBSD.org> <d6b37fbc-02f6-8cb0-63a6-42dc7b1ec989@FreeBSD.org> In-Reply-To: <d6b37fbc-02f6-8cb0-63a6-42dc7b1ec989@FreeBSD.org> --Onk434q0N4sITDfweVXgVJgsQwifpJoAI Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 9/14/16 4:22 PM, Guido Falsi wrote: > On 09/14/16 21:46, Mathieu Arnold wrote: >> Le 14/09/2016 =C3=A0 21:13, Guido Falsi a =C3=A9crit : >>> Author: madpilot >>> Date: Wed Sep 14 19:13:07 2016 >>> New Revision: 422151 >>> URL: https://svnweb.freebsd.org/changeset/ports/422151 >>> >>> Log: >>> Add PHP_DEFAULT=3D7.0 so that a package is build on the cluster wit= h >>> default ports configuration. >>> =20 >>> PR: 212684 >>> Submitted by: joshruehlig at gmail.com >>> Approved by: Daniel Ylitalo <daniel at blodan.se> (maintainer) >>> >> >> Please, revert this. >> >> We do not force PHP versions of modules/extensions, either you have th= e >> right default version, and it will build and work, or you don't have t= he >> right default version and it will be a two leg stool. >> >=20 > The reason I did this is there are already other PHP modules doing this= , > so I thought it was ok. >=20 > While I understand what the problem is this is a leaf port and such a > change causes no problems and allows the package to be built in the clu= ster. >=20 > Before reverting this I'd like to have an opinion from portmgr (CCed). >=20 > Meybe some cleaner way to allow php7 parts to be built on the cluster > should be made available, although I don't know what that can be right = now. >=20 It seems reasonable to me since it is NAMED php70-. Setting the default is done in python ports like this as well. Wrapping an IGNORE in !PACKAGE_BUILDING seems ok to me too. --=20 Regards, Bryan Drewery --Onk434q0N4sITDfweVXgVJgsQwifpJoAI-- --8Xd0w8ka7iLWtw2tjq5hLf62NGAGRLudG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJX2d+iAAoJEDXXcbtuRpfP/oUIALz83YfXskbeSLSgm0z/xnrI kWfObBMnba97yeOUwNS/VQ3Hxg2WM5gFHpNEZfZVGno9+9vubqd7pGGajL+pucIK GTI7zS4cdlbqMVCJzj04bsESxSrfZSypzNDNqLuP11DScibd6E/GAoyKXb0tCeEm 6lfDpgBkfXvCP9q3SJ2b30F++4T1bamAOlUm9MAvx+zvvlRcuHApYTR/KG9jr0nu VRNXSQG5Zm9N0R0KSy76n7e6yJqL0kXBFrYR6IkY2q5f5qWDnINQG8LwYdeu8rm6 pph7MDq/8lfXO+7DFVpGyMSpqDc3gPuEe1T84duxZZCLPlZvv6G5RwSNqMahVKw= =M3+w -----END PGP SIGNATURE----- --8Xd0w8ka7iLWtw2tjq5hLf62NGAGRLudG--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0f3a866e-505b-1cbf-32d1-b543949841ee>