From owner-svn-src-head@freebsd.org  Mon Aug 15 18:15:52 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1F9A0BBBA2A;
 Mon, 15 Aug 2016 18:15:52 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from mail.turbocat.net (mail.turbocat.net
 [IPv6:2a01:4f8:d16:4514::2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id DB07C1B7B;
 Mon, 15 Aug 2016 18:15:51 +0000 (UTC) (envelope-from hps@selasky.org)
Received: from laptop015.home.selasky.org (unknown [62.141.129.119])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id 0F2B81FE022;
 Mon, 15 Aug 2016 20:15:47 +0200 (CEST)
Subject: Re: svn commit: r303848 - head/sys/netgraph
To: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com>,
 Gleb Smirnoff <glebius@FreeBSD.org>
References: <201608081931.u78JV1Ve026577@repo.freebsd.org>
 <20160812183845.GJ1076@FreeBSD.org>
 <96EEC230-97EA-4686-9AFC-D5D6F98E70E8@gmail.com>
Cc: Sean Bruno <sbruno@FreeBSD.org>, Michael Zhilin <mizhka@gmail.com>,
 Garrett Cooper <ngie@FreeBSD.org>, sergey.dyatko@gmail.com,
 src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
From: Hans Petter Selasky <hps@selasky.org>
Message-ID: <9055748a-51c1-c6d7-b22d-52abde4d01f7@selasky.org>
Date: Mon, 15 Aug 2016 20:20:15 +0200
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101
 Thunderbird/45.0
MIME-Version: 1.0
In-Reply-To: <96EEC230-97EA-4686-9AFC-D5D6F98E70E8@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Aug 2016 18:15:52 -0000

On 08/13/16 00:23, Ngie Cooper (yaneurabeya) wrote:
>
>> On Aug 12, 2016, at 11:38, Gleb Smirnoff <glebius@FreeBSD.org> wrote:
>>
>>  Hi!
>>
>>  Sorry, I'm afraid this isn't a correct fix. Simply adding checks
>> against NULL to avoid panics at race conditions isn't a solution.
>>
>> I can provide help with this problem. It must be related to my
>> callout changes, in case if this is a very recent problem.
>>
>> Is it a recent problem or an old one?
>
> I should have requested that the change be revised or further qualified first… as I said in the CR:
>
> “””
> In D7209#150056, @bz wrote:
> Is this sudden problem possibly related to glebius' callout changes? I am not properly tracking things but if invariants changed and weren't reflected in the callers, that might explain.
> I don't know to be honest.
>
> I'll add glebius (I should have done that in the first place).
> “””
>

Hi Ngie,

Is this problem reproducable with projects/hps_head?

--HPS