From owner-svn-src-projects@freebsd.org Thu Jul 26 13:47:53 2018 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E4CB8104FB66 for ; Thu, 26 Jul 2018 13:47:52 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 8D7D18FA76; Thu, 26 Jul 2018 13:47:52 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 2609326379; Thu, 26 Jul 2018 13:47:52 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lj1-f169.google.com with SMTP id q127-v6so1557818ljq.11; Thu, 26 Jul 2018 06:47:52 -0700 (PDT) X-Gm-Message-State: AOUpUlEMFwOfWUYUjpdqWs5VYF+PHwMP/3DVdjrGCp3twN9atl/REdia 5EdUVuhnGwAUpditt+MQT7MCFNIhOrI7GYHXg1Q= X-Google-Smtp-Source: AAOMgpf6hiRBlM/IuY7cbn+toKHcBgSfG/mZPAXxYCiEl4cKwmmo+zgDfLDBRS8r5gJ+aS8crI9XzxDjZPWTtPOJ80s= X-Received: by 2002:a2e:4055:: with SMTP id n82-v6mr1633283lja.99.1532612870777; Thu, 26 Jul 2018 06:47:50 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a2e:5742:0:0:0:0:0 with HTTP; Thu, 26 Jul 2018 06:47:30 -0700 (PDT) In-Reply-To: <201807261332.w6QDWdQI045745@pdx.rh.CN85.dnsmgr.net> References: <20180726131959.qplqj62fkjzcfyid@mutt-hbsd> <201807261332.w6QDWdQI045745@pdx.rh.CN85.dnsmgr.net> From: Kyle Evans Date: Thu, 26 Jul 2018 08:47:30 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r336731 - projects/bectl/sbin/bectl To: "Rodney W. Grimes" Cc: Shawn Webb , src-committers , svn-src-projects@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jul 2018 13:47:53 -0000 On Thu, Jul 26, 2018 at 8:32 AM, Rodney W. Grimes wrote: > -- Start of PGP signed section. >> On Thu, Jul 26, 2018 at 04:07:37AM +0000, Kyle Evans wrote: >> > Author: kevans >> > Date: Thu Jul 26 04:07:36 2018 >> > New Revision: 336731 >> > URL: https://svnweb.freebsd.org/changeset/base/336731 >> > >> > Log: >> > bectl(8): Redo jail using jail(3) API >> > >> > The jail is created with allow.mount, allow.mount.devfs, and >> > enforce_statfs=1. Upon creation, we immediately attach, chdir to "/", and >> > drop the user into a shell inside the jail. >> > >> > The default IP for this is arbitrarily 10.20.30.40. >> >> It seems this would only allow working in a single jailed BE at a >> time, correct? > > Also it is just bad practice to use arbitrary IP's from > rfc1918 space. IMHO it would be better to pick a > rfc3927 link local address, or one of the rfc5737 test > network addresses. > > Please see RFC5735 page 6, table in section 4, no > place in FreeBSD base system should we be shipping > stuff that uses rfc1918, that is private space that > does not belong to the OS. > Right on both accounts (Shawn + Rod)... I changed it from an arbitrary IP in 192.168/16 space that was conflicting with my local network (heh... that was fun) with the intent of later changing it to just be configurable rather than hard-coding an IP [1] because I think that no matter what choice I try to go with, someone's going to want something else. I'd rather not make such choices at all and force you to instead specify an IP every time, a la "bectl jail testenv 10.8.0.100". The default remains 10.20.30.40 until that time, though, and it seemed that anyone wanting to test this should be aware. [1] see the "XXX TODO" I dropped in the area, which mentions the former and meant to hint at the latter