Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 19 Jan 1999 15:13:25 +1100 (EST)
From:      "Daniel O'Callaghan" <danny@hilink.com.au>
To:        freebsd-bugs@FreeBSD.ORG
Subject:   Re: cvs commit: src/usr.bin/yacc/test ftp.y (fwd)
Message-ID:  <Pine.BSF.3.96.990119150419.22692S-100000@helium.clari.net.au>

next in thread | raw e-mail | index | archive | help

My latest commit was tidying up a y2k nit in src/usr.bin/yacc/test/ftp.y

Peter Jeremy pointed out that it was a test directory, and changes to
source need corresponding changes to the output comparison files.  On
further inspection, neither of us can see that yacc/test/ is usable in its
current form.  Should the test/ subdir of usr.bin/yacc be moved to the
Attic or fixed or what?  The output comparison files are already useless
for testing yacc.

Danny

---------- Forwarded message ----------
Date: Tue, 19 Jan 1999 14:16:21 +1100
From: Peter Jeremy <peter.jeremy@auss2.alcatel.com.au>
To: danny@hilink.com.au
Subject: Re: cvs commit: src/usr.bin/yacc/test ftp.y

Hi Danny,

>I can't see how to actually run the test from the Makefile.
I can't either.  Possibly the original Makefile supported it, but it
wasn't carried across to the 4.4BSD Makefile.

>'diff -u ftp.tab.c y.tab.c' produces a lot of output.
Looking at the output, it seems that someone has done some cleaning up
in the code generated by yacc - adding const's and various constructs
to stop some gcc warnings.  Reading back thru the RCS logs, it seems
that a variety of fixes have been made in skeleton.c, without the
corresponding changes in the expected output files.

>What to do?
I suspect the entire test directory can be junked, but you should
probably discuss that with core (or at least Bruce Evans or Peter Wemm
who seem to have originated most of the recent changes).

Peter



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.96.990119150419.22692S-100000>